remove remote_read option and point to use direct queries for data retrieval #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
force-pushed
the
disable-remote-read
branch
from
6522be2 to
db98498
Compare
…data retrieval Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
paulfantom
force-pushed
the
disable-remote-read
branch
from
db98498 to
24d303e
Compare
nhudson
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Since
remote_readoffers poor performance for querying data and promscale can be queried directly as well as use prometheus alerts there seem to be no reason to configure this option. This is potentially a breaking change for some user so I am bumping major version as well as putting upgrade path information.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist