Allow penv values to be falsy

glossings · glossings · commit 38ce593c6026 · 2025-09-09T20:47:09.000-05:00
diff --git a/packages/superdough/helpers.mjs b/packages/superdough/helpers.mjs
@@ -174,7 +174,7 @@ let curves = ['linear', 'exponential'];
 export function getPitchEnvelope(param, value, t, holdEnd) {
   // envelope is active when any of these values is set
   const hasEnvelope = value.pattack ?? value.pdecay ?? value.psustain ?? value.prelease ?? value.penv;
-  if (!hasEnvelope) {
+  if (hasEnvelope === undefined) {
     return;
   }
   const penv = nanFallback(value.penv, 1, true);

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ let curves = ['linear', 'exponential'];`
`174`	`174`	`export function getPitchEnvelope(param, value, t, holdEnd) {`
`175`	`175`	`// envelope is active when any of these values is set`
`176`	`176`	`const hasEnvelope = value.pattack ?? value.pdecay ?? value.psustain ?? value.prelease ?? value.penv;`
`177`		`- if (!hasEnvelope) {`
	`177`	`+ if (hasEnvelope === undefined) {`
`178`	`178`	`return;`
`179`	`179`	`}`
`180`	`180`	`const penv = nanFallback(value.penv, 1, true);`