ci: support Go modules #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TinyGo started supporting Go modules, there was an error in CI. The commit 7967e82 tries to fix that, but I think the underlying issue is that we're checking out in GOROOT, which is definitely not a supported configuration. I think the best solution is to just switch to using Go modules, by adding a go.mod file in the root. I've set it to Go version 1.13 as that is the first Go version that supports number literals, but it could be set to any supported Go version (1.11-1.14). Since we use Go modules, the location of the drivers checkout should not matter so I've removed it. This fixes the error on CircleCI.
Member
|
Much better solution, thanks @aykevl Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TinyGo started supporting Go modules, there was an error in CI. The commit 7967e82 tries to fix that, but I think the underlying issue is that we're checking out in
GOROOT, which is definitely not a supported configuration.I think the best solution is to just switch to using Go modules, by adding a go.mod file in the root. I've set it to Go version 1.13 as that is the first Go version that supports number literals, but it could be set to any supported Go version (1.11-1.14).
Since we use Go modules, the location of the drivers checkout should not matter so I've removed it. This fixes the error on CircleCI.