Skip to content

Commit 201592d

Browse files
aykevldeadprogram
authored andcommitted
ci: add AVR timers test
Add the timers test because they now work correctly on AVR, probably as a result of the reflect refactor: #2640 I've also updated a few of the other tests to indicate the new status and why they don't work. It's no longer because of compiler errors, but because of linker or runtime errors (which is at least some progress). For example, I found that testdata/reflect.go works if you disable `testAppendSlice` and increase the stack size.
1 parent 4766217 commit 201592d

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

main_test.go

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -180,28 +180,25 @@ func runPlatTests(options compileopts.Options, tests []string, t *testing.T) {
180180
// Skip the ones that aren't.
181181
switch name {
182182
case "reflect.go":
183-
// Reflect tests do not work due to type code issues.
183+
// Reflect tests do not run correctly, probably because of the
184+
// limited amount of memory.
184185
continue
185186

186187
case "gc.go":
187188
// Does not pass due to high mark false positive rate.
188189
continue
189190

190191
case "json.go", "stdlib.go", "testing.go":
191-
// Breaks interp.
192+
// Too big for AVR. Doesn't fit in flash/RAM.
192193
continue
193194

194195
case "math.go":
195-
// Stuck somewhere, not sure what's happening.
196+
// Needs newer picolibc version (for sqrt).
196197
continue
197198

198199
case "cgo/":
199-
// CGo does not work on AVR.
200-
continue
201-
202-
case "timers.go":
203-
// Doesn't compile:
204-
// panic: compiler: could not store type code number inside interface type code
200+
// CGo function pointers don't work on AVR (needs LLVM 16 and
201+
// some compiler changes).
205202
continue
206203

207204
default:

0 commit comments

Comments
 (0)