Skip to content

Conversation

@aykevl
Copy link
Member

@aykevl aykevl commented May 16, 2020

This also implements DisableInterrupts/EnableInterrupts for RISC-V, as those operations were needed to implement a few libcalls.

This PR replaces the out-of-date and incomplete PR #298. Changes since then:

  • Added implementations of libcalls for Cortex-M and RISC-V.
  • Added support for the sync/atomic.Value type.
  • Removed src/runtime/atomic.go, which had a few (unsafe!) implementations of atomic operations.

This also implements DisableInterrupts/EnableInterrupts for RISC-V, as
those operations were needed to implement a few libcalls.
@deadprogram
Copy link
Member

@jaddr2line any feedback before we merge?

@niaow niaow self-requested a review May 28, 2020 12:47
Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram deadprogram merged commit fed433c into dev May 28, 2020
@deadprogram deadprogram deleted the atomic-2 branch May 28, 2020 13:11
@niaow niaow added this to the v0.14 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants