-
Notifications
You must be signed in to change notification settings - Fork 997
all: changeover to eliminate all direct use of master/slave terminology #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6f2238 to
866e4ee
Compare
|
@johanbrandhorst any way to change the branch used by the repo used for the Arch release? https://github.com/tinygo-org/tinygo/blob/dev/.circleci/config.yml#L368 |
Couldn't find any information about this so I've posted a question on the AUR forum: https://bbs.archlinux.org/viewtopic.php?pid=1914409#p1914409. |
|
Thanks! |
|
I could be wrong, but the way I understood https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names was that the new signal names are (usually) SDO and SDI (similar to TX and RX). Additionally, I find |
It doesn't seem to be possible right now, but I've asked if it can be changed in the future https://bbs.archlinux.org/viewtopic.php?pid=1914523#p1914523. |
866e4ee to
62d4ecf
Compare
|
@aykevl I like the SDO/SDI better as well. Changes made and force pushed. @johanbrandhorst thanks for checking into it. |
62d4ecf to
4337ba0
Compare
4337ba0 to
4d3eb62
Compare
|
I think that I have now handled all of the boards currently in the |
|
@deadprogram could you update the default branch? |
aykevl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree this is a good change in principle, we should be careful to use the correct terminology. I'm worried some changes may make things less clear. We can't really do this kind of thing again without good reason because it will break existing programs.
4d3eb62 to
befe223
Compare
|
Updated again based on feedback, and also for new boards added since I started this PR. |
|
Anything else needed for this PR? |
aykevl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits for consistency, but really it looks good to me now. Feel free to fix this (or not) and merge, LGTM.
3c355da to
030003d
Compare
Signed-off-by: deadprogram <ron@hybridgroup.com>
030003d to
d2769b1
Compare
|
Looks good to me, so merging. There is a CI failure but that one already existed before this PR (and should be fixed separately). |
This PR is to changeover to eliminate all direct use of master/slave terminology both for the Git repo, and also the TinyGo peripherals. See https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names
We will also need to change the
masterbranch name torelease, and change the default branch in Github.