Skip to content

Conversation

@deadprogram
Copy link
Member

@deadprogram deadprogram commented Jul 7, 2020

This PR is to changeover to eliminate all direct use of master/slave terminology both for the Git repo, and also the TinyGo peripherals. See https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names

We will also need to change the master branch name to release, and change the default branch in Github.

@deadprogram deadprogram force-pushed the release-branch-changeover branch from d6f2238 to 866e4ee Compare July 7, 2020 17:04
@deadprogram
Copy link
Member Author

deadprogram commented Jul 7, 2020

@johanbrandhorst any way to change the branch used by the repo used for the Arch release? https://github.com/tinygo-org/tinygo/blob/dev/.circleci/config.yml#L368

@johanbrandhorst
Copy link
Member

@johanbrandhorst any way to change the branch used by the repo used for the Arch release? https://github.com/tinygo-org/tinygo/blob/dev/.circleci/config.yml#L368

Couldn't find any information about this so I've posted a question on the AUR forum: https://bbs.archlinux.org/viewtopic.php?pid=1914409#p1914409.

@deadprogram
Copy link
Member Author

Thanks!

@aykevl
Copy link
Member

aykevl commented Jul 8, 2020

I could be wrong, but the way I understood https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names was that the new signal names are (usually) SDO and SDI (similar to TX and RX). Additionally, I find SDO and SDI easier to understand.

@johanbrandhorst
Copy link
Member

@johanbrandhorst any way to change the branch used by the repo used for the Arch release? https://github.com/tinygo-org/tinygo/blob/dev/.circleci/config.yml#L368

Couldn't find any information about this so I've posted a question on the AUR forum: https://bbs.archlinux.org/viewtopic.php?pid=1914409#p1914409.

It doesn't seem to be possible right now, but I've asked if it can be changed in the future https://bbs.archlinux.org/viewtopic.php?pid=1914523#p1914523.

@deadprogram deadprogram force-pushed the release-branch-changeover branch from 866e4ee to 62d4ecf Compare July 8, 2020 16:02
@deadprogram
Copy link
Member Author

@aykevl I like the SDO/SDI better as well. Changes made and force pushed.

@johanbrandhorst thanks for checking into it.

@deadprogram deadprogram force-pushed the release-branch-changeover branch from 62d4ecf to 4337ba0 Compare July 8, 2020 16:12
@deadprogram deadprogram added this to the v0.14 milestone Jul 8, 2020
@deadprogram deadprogram force-pushed the release-branch-changeover branch from 4337ba0 to 4d3eb62 Compare July 8, 2020 20:26
@deadprogram
Copy link
Member Author

I think that I have now handled all of the boards currently in the dev branch. This PR should now be ready.

@sevki
Copy link

sevki commented Jul 8, 2020

@deadprogram could you update the default branch?
Just spent an ungodly amount of time compiling an obsolete branch 😂

@deadprogram
Copy link
Member Author

@sevki see https://github.com/tinygo-org/tinygo/blob/master/CONTRIBUTING.md#how-to-use-our-github-repository

Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree this is a good change in principle, we should be careful to use the correct terminology. I'm worried some changes may make things less clear. We can't really do this kind of thing again without good reason because it will break existing programs.

@deadprogram deadprogram force-pushed the release-branch-changeover branch from 4d3eb62 to befe223 Compare July 14, 2020 04:40
@deadprogram
Copy link
Member Author

Updated again based on feedback, and also for new boards added since I started this PR.

@deadprogram
Copy link
Member Author

Anything else needed for this PR?

Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits for consistency, but really it looks good to me now. Feel free to fix this (or not) and merge, LGTM.

Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram deadprogram force-pushed the release-branch-changeover branch from 030003d to d2769b1 Compare July 23, 2020 19:50
@aykevl
Copy link
Member

aykevl commented Jul 23, 2020

Looks good to me, so merging. There is a CI failure but that one already existed before this PR (and should be fixed separately).

@aykevl aykevl merged commit d1c4ed6 into dev Jul 23, 2020
@aykevl aykevl deleted the release-branch-changeover branch July 23, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants