add wasm-abi field in TargetSpec && set generic for WASI by default #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
changed the title
Signed-off-by: mathetake <takeshi@tetrate.io>
Signed-off-by: mathetake <takeshi@tetrate.io>
mathetake
changed the title
mathetake
commented
Oct 1, 2020
aykevl
reviewed
Oct 2, 2020
builder/build.go
Outdated
| // Use -wasm-abi=generic to disable this behaviour. | ||
| if config.Options.WasmAbi == "js" && strings.HasPrefix(config.Triple(), "wasm") { | ||
| if config.Options.WasmAbi != "" { | ||
| config.Target.WasmAbi = config.Options.WasmAbi |
Member
There was a problem hiding this comment.
Please do not modify the config.Target field, it should contain exactly what is extracted from the JSON files.
Instead, you can either:
- Add a getter to the
configvariable (*compileopts.Config), so you can simply callconfig.WasmAbi()to get the value. - Use a local variable instead.
The getter would be slightly cleaner, as it matches the pattern of other configurations (CGO_ENABLED, GC, NeedsStackObjects, etc).
Member
There was a problem hiding this comment.
@mathetake thanks for the addition.
@aykevl anything else needed for us to merge this now?
Signed-off-by: mathetake <takeshi@tetrate.io>
Member
|
No that's all. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-abifield in TargetSpec (defaults to the empty string)-wasm-abiflag fromjsto the empty stringwasm-abivalue by-wasm-abiwhen the flag is set to non-empty stringwasm-abifield values forwasm.jsonandwasi.jsonjsfor wasm.jsongenericfor wasi.json