-
Notifications
You must be signed in to change notification settings - Fork 997
teensy36: add to smoketest #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code looks fine. I was able to rebuild However, I'm not getting any output on UART1 RX/TX (digital 0/1) when flashing Not sure if this was just introduced or if there was a problem before these changes. Will have to revert and test again. |
|
@ardnew did you ever have a chance to test this again? |
|
@deadprogram i havent yet, no. As soon as i finish some stuff for actual work (this week) i will have a little free time to investigate |
c63cbac to
f924eb3
Compare
|
Rebased. |
f924eb3 to
858406a
Compare
|
Let's try that again. Now rebased on top of the (current) dev branch instead of an older version to fix the merge conflict. |
|
Looks like I introduced a bug from branch Build tag This will be fixed once branch I think this precisely justifies adding With that bug fixed, I retested this (which depended on tinygo built from branch |
This required some changes to the UART code to get it to compile on Go 1.11.
858406a to
6109c28
Compare
|
Now merging, thanks everyone! |
This required some changes to the UART code to get it to compile on Go 1.11.
Smoke tests are very important to make sure
-target=teensy36doesn't break unexpectedly.@ardnew can you take a look at these changes and test them on a Teensy 3.6? I don't have such a device.