os: disable TestClearenv for now, it is very flaky. Also reduce verbosity. #2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @dkegel-fastly merging as the most pragmatic for now. |
dgryski
added a commit
to dgryski/tinygo
that referenced
this pull request
Feb 22, 2022
Removed as flaky in tinygo-org#2603
deadprogram
pushed a commit
that referenced
this pull request
Apr 11, 2022
Removed as flaky in #2603
ardnew
pushed a commit
to ardnew/tinygo
that referenced
this pull request
Jun 21, 2022
Removed as flaky in tinygo-org#2603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with TestClearenv is that it assumes os.Environ() returns a copy of the environment, but in tinygo, it returns pointers to the live environment. Thus in tinygo, os.Environ() can go invalid the moment any environment variable is deleted.
Probably need to decide whether this behavior is ok, and if so, rewrite that test to call os.Environ() after each deletion, or something.
See #2646