Skip to content

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Jun 11, 2022

Draft to await result of the discussion in #2903 (comment).

@dgryski
Copy link
Member

dgryski commented Jun 24, 2022

While we're here we should probably update the calls to ioutil/* to the appropriate io or os methods.

@QuLogic
Copy link
Contributor

QuLogic commented Aug 7, 2022

Since this seems a more relevant place to follow up than #2903 (comment), I'll post here. We have Go 1.16 in Fedora 35, Go 1.18 in Fedora 36, and Go 1.19 in Fedora Rawhide (to be 37). Fedora 35 goes EOL one month after Fedora 37 is out (so approximately November).

However, since #3039 is now in, dropping support for LLVM 13 already means that dev would no longer work on Fedora 35. So there's no reason not to apply this one as well, from a Fedora point of view.

@QuLogic
Copy link
Contributor

QuLogic commented Aug 8, 2022

Oh, actually, since TinyGo 0.24.0 requires golang.org/x/tools 0.1.11, which itself requires Go 1.17, I think Fedora 35 is already unsupported, so its constraints are no longer an issue.

@aykevl
Copy link
Member Author

aykevl commented Aug 28, 2022

@QuLogic thanks!

I have now rebased and updated it after multiple changes in the dev branch (mostly generics and timers). Right now I have a local branch that adds support for Go assembly files on Linux (32-bit and 64-bit) but it uses generics - because I didn't want to copy the ELF writing code between ELF32 and ELF64. Therefore, this branch requires Go 1.18.

@aykevl aykevl marked this pull request as ready for review August 28, 2022 22:04
@aykevl
Copy link
Member Author

aykevl commented Aug 28, 2022

@deadprogram looks like the TinyHCI runner might need a Go update.

@aykevl aykevl mentioned this pull request Aug 28, 2022
@deadprogram
Copy link
Member

@aykevl fixed TinyHCI and now all passing.

@deadprogram
Copy link
Member

@aykevl thanks for all the work on this, and thanks @QuLogic for the detailed review.

Now merging! ✂️ ✂️

@deadprogram deadprogram merged commit 4695da8 into dev Aug 30, 2022
@deadprogram deadprogram deleted the drop-go1.17 branch August 30, 2022 10:38
@deadprogram
Copy link
Member

Something not working as expected after merge into dev

CI failing on macOS
https://github.com/tinygo-org/tinygo/runs/8090351014?check_suite_focus=true#step:12:19781

@aykevl
Copy link
Member Author

aykevl commented Aug 30, 2022

Yes, the timers test is flaky on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants