doc: fix a typo in the rtcinterrupt example #3981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Ege <ch@ege.io>
Member
|
@graugans those seem like very good suggestions. Can you please add that? |
Contributor
Author
I'll do my best. |
The examples shall be short and not overloaded with too much information. The details can be read up in the documentation. Signed-off-by: Christian Ege <ch@ege.io>
Contributor
Author
|
I have added a link to the online documentation. |
Member
|
Thanks @graugans for the doc improvement. Now squash/merging. |
crypto-smoke
pushed a commit
to meshnet-gophers/tinygo
that referenced
this pull request
Feb 14, 2024
docs: fix a typo in the rtcinterrupt example, also provide a link to the interrupt online doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this while glancing through the examples.
Maybe it also makes sense to link to the docs like this: https://tinygo.org/docs/concepts/compiler-internals/heap-allocation/
Is it worth adding the hint about blocking and memory to the interrupt documentation page https://tinygo.org/docs/concepts/compiler-internals/interrupts/ as well? This came to my mind when I was thinking if
fmt.Println()is blocking or not I am pretty sure it does :-)