Fix ticks on 32-bit ARM on Linux #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems reasonable. Merging. |
aykevl
reviewed
Nov 11, 2019
| tv_sec int64 | ||
| tv_nsec int64 | ||
| tv_sec timeT | ||
| tv_nsec timeT |
Member
There was a problem hiding this comment.
This can be implemented much simpler: int is 32-bit on 32-bit systems and 64-bit on 64-bit systems. This matches gc and I see no reason to change that behavior.
This is different from C because Go is not tied to C legacy where int is usually 32-bit even on 64-bit platforms and you can't rely on any particular behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem currently with #680 failing to pass tests appears to be that
ticks()is returning corrupted time values. This PR fixes that by correcting some definitions for timing functions.