Check for non-static allocas #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
check-error-locations
branch
from
0e44702 to
0fc95f7
Compare
Member
Author
deadprogram
changed the title
Member
|
@aykevl this needs to be rebased again to be merged. |
Non-static allocas are disallowed for a number of reasons, so check for their presence. See the commit diff for details.
aykevl
force-pushed
the
check-error-locations
branch
from
0fc95f7 to
b261d97
Compare
Member
Author
|
Rebased. |
Member
|
Can this be merged now? |
Member
Author
|
Yes, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with two commits. The first one might be useful in general (and perhaps be submitted separately). The second one should not be merged now, but only after all non-static allocas are avoided in TinyGo (after at least #773 and #745 have been merged).