1200 baud auto-reset over USB for nrf52840 #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgould
force-pushed
the
feature/nrf52840-auto-reset
branch
from
aeaabca to
a297df0
Compare
bgould
changed the title
Member
Author
|
Ok, rebased and tested on Adafruit Clue and Circuit Playground Bluefruit. Should be good to go pending review |
aykevl
reviewed
Feb 21, 2020
Member
Author
|
Thank you for the feedback @aykevl, I've incorporated your suggestions in the latest commit. |
Member
|
Looks good! I've merged these changes in the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #883, and should be rebased once that one is merged. It implements the functionality for auto-resetting into the UF2 bootloader when a 1200 baud signal is received.
I protected this functionality with build tags since it depends on the UF2 bootloader, and also to enable disabling this functionality if desired. If preferable however it could be included in the firmware by default without build tags.