Refactor Optimize function #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for moving the Optimize function to the transform package.
This allows packages other than the compiler to know (from a single source of truth) which implemenation is used for Go func values. This refactor is necessary to be able to move the Optimize function to the transform package.
aykevl
force-pushed
the
refactor-optimizer
branch
from
4411662 to
5c1b88f
Compare
Member
Author
|
Rebased to make CI succeed. |
Member
|
Looks good to me. @jaddr2line any feedback before I merge this? |
niaow
requested changes
Mar 19, 2020
This refactor is a prerequisite to much larger refactors in the compiler.
aykevl
force-pushed
the
refactor-optimizer
branch
from
5c1b88f to
f46e834
Compare
niaow
approved these changes
Mar 21, 2020
Member
|
Thanks @aykevl and @jaddr2line now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is a prerequisite to a much larger refactor in the compiler, see #746.