interp: improve support for load/store instructions #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
interp-load-bitcast
branch
from
6ced0e3 to
e4e48ee
Compare
Member
Author
|
This is now ready for review. |
Member
Author
|
Well not quite, CI broke. I think it will be fixed with the removal of |
Member
|
Looks good. Will put in a final review once this is rebased and CI passes. |
Member
|
@aykevl I think you can now rebase this PR, as the dependencies are merged. |
aykevl
force-pushed
the
interp-load-bitcast
branch
from
e4e48ee to
2e24271
Compare
Member
Author
|
Rebased, and now it doesn't regress for image/color/palette. |
Member
|
Hmm somethingn went wrong there: |
Member
Author
|
Well that's unfortunate. I'll need to look into that. |
Member
|
Can this PR now be worked on again? |
Previously, whether a value could be safely loaded from or stored to was based on some heuristics. This commit fixes that by making sure the underlying global is really not part of the dirty set (which must be operated on at runtime instead of compile time). Together with the previous commit, this commit gets a number of standard library packages to compile: * crypto/dsa * crypto/ed25519 * crypto/elliptic * crypto/rand * go/constant * math/big
aykevl
force-pushed
the
interp-load-bitcast
branch
from
2e24271 to
b446ca5
Compare
Member
Author
|
This PR is no longer relevant since #1430 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of two commits that allows a significant number of packages to compile (perhaps most importantly
math/big):However, it also breaks the image/color/palette package. I am hopeful that this will be fixed with the removal of the
runtime.isnilmechanism which appears to cause this problem.