Fix: Save duplicated objects after foreign keys updated #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akollek
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
Hey @jackton1 , came across this bug while using django-clone, let me know what you think of the fix |
jackton1
requested changes
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #633 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 287 288 +1
=========================================
+ Hits 287 288 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@all-contributors please add @Akollek for code bug test |
Contributor
|
I've put up a pull request to add @Akollek! 🎉 |
Member
LGTM, Thanks for updating the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
It seems that when copying a many to one relationship a duplicate of the other object is created, but the foreign key change on the original object isn't saved. This evaded being caught by tests since the unsaved object was used for comparison.
The solution
Save the object again after coping all foreign keys.