Skip to content

Support Date objects #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Support Date objects #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16925d6
Support `Date` objects
tjenkinson Aug 28, 2024
a1633b2
Use the unix time instead as shorter
tjenkinson Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
259 changes: 259 additions & 0 deletions src/__snapshots__/sql-cursor-pagination.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6001,6 +6001,265 @@ exports[`SqlCursorPagination > selects the third row when selecting the last one
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 1`] = `Infinity`;

exports[`SqlCursorPagination > supports \`Date\` objects 2`] = `
{
"bindings": [],
"strings": [
"\`created_at\` asc",
],
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 3`] = `
{
"bindings": [],
"sql": "\`created_at\` asc",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 4`] = `
{
"bindings": [],
"sql": "\`created_at\` asc",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 5`] = `
{
"bindings": [],
"sql": "\`created_at\` asc",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 6`] = `
{
"bindings": {},
"sql": "\`created_at\` asc",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 7`] = `
{
"bindings": [],
"strings": [
"\`created_at\` asc",
],
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 8`] = `
{
"bindings": [],
"strings": [
"1",
],
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 9`] = `
{
"bindings": [],
"sql": "1",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 10`] = `
{
"bindings": [],
"sql": "1",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 11`] = `
{
"bindings": [],
"sql": "1",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 12`] = `
{
"bindings": {},
"sql": "1",
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 13`] = `
{
"bindings": [],
"strings": [
"1",
],
}
`;

exports[`SqlCursorPagination > supports \`Date\` objects 14`] = `
{
"edges": [
{
"cursor": "HZTLrCVKXHMzAYEdWfgURQ7un1QyVeEPL6lAUVQ33ks.qQxXeujE6leOMjlBqlDpl83sYRqLghCcshcw785yfQunE0diEK-YldGzlgK4-Ni9E-pgrdAouIQPZXVFpeA3mjKaaRGDpjsfh-0MgQ",
"node": {
"admin": 0,
"created_at": 1970-01-19T13:42:23.417Z,
"email": "purus.accumsan@icloud.com",
"email_alias": "purus.accumsan@icloud.com",
"first_name": "Cooper",
"id": 4,
"last_name": "Molina",
},
},
{
"cursor": "9kuaH_geuEx9b7pqVk8UCfIgWu3F2E-EOtIO2mUrv54.wqA2-aCh9bJddA_EzjFahbpYTxgM8JXoFYl8Dr-iSQPw6O3TqbeoPq9_47xEON4wu3toImr3Q7Y4an7KDqmwPyaPu_ON4tmal5p5Sw",
"node": {
"admin": 1,
"created_at": 1970-01-19T21:08:52.719Z,
"email": "diam.vel@outlook.edu",
"email_alias": "diam.vel@outlook.edu",
"first_name": "Anika",
"id": 5,
"last_name": "Molina",
},
},
{
"cursor": "-K9Y5xUBWrTdFz-dmNahvxztq1dwhM-isNGMB7NlOc4.6j7YrRISP6jDmoP_W4uEHzZ_nrwnBtiditLA6H7u4RpLVpXvKxyQ0k-X_pQdf-qeGSM3-BggrmunVnhy2ZFETGzuP9BDPNqhGELqTg",
"node": {
"admin": 1,
"created_at": 1970-01-20T01:45:59.350Z,
"email": "eu@hotmail.ca",
"email_alias": "eu@hotmail.ca",
"first_name": "Joseph",
"id": 3,
"last_name": "Rhodes",
},
},
{
"cursor": "6BLaEvR9FVRWrumkh9xu0Nl8kRThMiMs44dvLrzUfus.855Bup9aVIk40RtajQ72DHw1WmCto1QeUx9Rp5llU22HJzmhdmU93BwD1WHpZV3Dusq3Eef6GNhmKwEgwPFK840HRAnaYYy9bLHvXg",
"node": {
"admin": 0,
"created_at": 1970-01-20T05:48:58.189Z,
"email": "rhoncus.donec@aol.edu",
"email_alias": "rhoncus.donec@aol.edu",
"first_name": "Anika",
"id": 1,
"last_name": "Duncan",
},
},
{
"cursor": "M7g1i1GiVPuiWGJvpXCnTOMBroEDAx6euOCo3-lVAr0.ltHPRQBF8AwVGmY7KojXc-mFSNvGCod9KQddayPzrYSYBO4MPCPqEsosakieakfA7iiaqvsRELYWdKUV1j0wAAjPD89iKsiieBy2Dg",
"node": {
"admin": 0,
"created_at": 1970-01-20T10:35:12.324Z,
"email": "ut.nisi@yahoo.org",
"email_alias": "ut.nisi@yahoo.org",
"first_name": "Jermaine",
"id": 2,
"last_name": "O'connor",
},
},
],
"pageInfo": {
"endCursor": "M7g1i1GiVPuiWGJvpXCnTOMBroEDAx6euOCo3-lVAr0.ltHPRQBF8AwVGmY7KojXc-mFSNvGCod9KQddayPzrYSYBO4MPCPqEsosakieakfA7iiaqvsRELYWdKUV1j0wAAjPD89iKsiieBy2Dg",
"hasNextPage": false,
"hasPreviousPage": false,
"startCursor": "HZTLrCVKXHMzAYEdWfgURQ7un1QyVeEPL6lAUVQ33ks.qQxXeujE6leOMjlBqlDpl83sYRqLghCcshcw785yfQunE0diEK-YldGzlgK4-Ni9E-pgrdAouIQPZXVFpeA3mjKaaRGDpjsfh-0MgQ",
},
Symbol(edgesWithRawCursor): [
{
"cursor": "HZTLrCVKXHMzAYEdWfgURQ7un1QyVeEPL6lAUVQ33ks.qQxXeujE6leOMjlBqlDpl83sYRqLghCcshcw785yfQunE0diEK-YldGzlgK4-Ni9E-pgrdAouIQPZXVFpeA3mjKaaRGDpjsfh-0MgQ",
"node": {
"admin": 0,
"created_at": 1970-01-19T13:42:23.417Z,
"email": "purus.accumsan@icloud.com",
"email_alias": "purus.accumsan@icloud.com",
"first_name": "Cooper",
"id": 4,
"last_name": "Molina",
},
"rawCursor": {
"fields": {
"created_at": 1604543417,
},
"queryName": "TestQuery",
},
},
{
"cursor": "9kuaH_geuEx9b7pqVk8UCfIgWu3F2E-EOtIO2mUrv54.wqA2-aCh9bJddA_EzjFahbpYTxgM8JXoFYl8Dr-iSQPw6O3TqbeoPq9_47xEON4wu3toImr3Q7Y4an7KDqmwPyaPu_ON4tmal5p5Sw",
"node": {
"admin": 1,
"created_at": 1970-01-19T21:08:52.719Z,
"email": "diam.vel@outlook.edu",
"email_alias": "diam.vel@outlook.edu",
"first_name": "Anika",
"id": 5,
"last_name": "Molina",
},
"rawCursor": {
"fields": {
"created_at": 1631332719,
},
"queryName": "TestQuery",
},
},
{
"cursor": "-K9Y5xUBWrTdFz-dmNahvxztq1dwhM-isNGMB7NlOc4.6j7YrRISP6jDmoP_W4uEHzZ_nrwnBtiditLA6H7u4RpLVpXvKxyQ0k-X_pQdf-qeGSM3-BggrmunVnhy2ZFETGzuP9BDPNqhGELqTg",
"node": {
"admin": 1,
"created_at": 1970-01-20T01:45:59.350Z,
"email": "eu@hotmail.ca",
"email_alias": "eu@hotmail.ca",
"first_name": "Joseph",
"id": 3,
"last_name": "Rhodes",
},
"rawCursor": {
"fields": {
"created_at": 1647959350,
},
"queryName": "TestQuery",
},
},
{
"cursor": "6BLaEvR9FVRWrumkh9xu0Nl8kRThMiMs44dvLrzUfus.855Bup9aVIk40RtajQ72DHw1WmCto1QeUx9Rp5llU22HJzmhdmU93BwD1WHpZV3Dusq3Eef6GNhmKwEgwPFK840HRAnaYYy9bLHvXg",
"node": {
"admin": 0,
"created_at": 1970-01-20T05:48:58.189Z,
"email": "rhoncus.donec@aol.edu",
"email_alias": "rhoncus.donec@aol.edu",
"first_name": "Anika",
"id": 1,
"last_name": "Duncan",
},
"rawCursor": {
"fields": {
"created_at": 1662538189,
},
"queryName": "TestQuery",
},
},
{
"cursor": "M7g1i1GiVPuiWGJvpXCnTOMBroEDAx6euOCo3-lVAr0.ltHPRQBF8AwVGmY7KojXc-mFSNvGCod9KQddayPzrYSYBO4MPCPqEsosakieakfA7iiaqvsRELYWdKUV1j0wAAjPD89iKsiieBy2Dg",
"node": {
"admin": 0,
"created_at": 1970-01-20T10:35:12.324Z,
"email": "ut.nisi@yahoo.org",
"email_alias": "ut.nisi@yahoo.org",
"first_name": "Jermaine",
"id": 2,
"last_name": "O'connor",
},
"rawCursor": {
"fields": {
"created_at": 1679712324,
},
"queryName": "TestQuery",
},
},
],
}
`;

exports[`SqlCursorPagination > supports field aliases 1`] = `2`;

exports[`SqlCursorPagination > supports field aliases 2`] = `
Expand Down
11 changes: 10 additions & 1 deletion src/cursor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,16 @@ export function buildCursor<TNode extends Record<string, unknown>>({
if (!(alias in node)) {
throw new ErrUnexpected(`"${alias}" field is missing`);
}
fields[alias] = FieldValue.parse(node[alias]);
const value = node[alias];
if (value instanceof Date) {
const resolved = value.getTime();
if (!Number.isFinite(resolved)) {
throw new ErrUnexpected(`Invalid date in "${alias}" field`);
}
fields[alias] = resolved;
} else {
fields[alias] = FieldValue.parse(value);
}
}

return { fields, queryName };
Expand Down
Loading