Feature/blacklist #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 10, 2017 12:18
Collaborator
|
@tjoskar thanks for the PR! I'll review it soon ;) |
welcoMattic
approved these changes
Dec 11, 2017
tjoskar
force-pushed
the
feature/blacklist
branch
from
68fef85 to
608d2d3
Compare
There was a bug in version 2.2.0 and since node 6 don't use package-lock it fails but now when 2.2.1 is released it works fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
This PR is a total rewrite of the current logic, mainly because I wanted to add some unit test and make it possible to dry run the script.
I also removed yarn and added
package-lock.jsoninstead.And because of the use ofpromisifyonly node >= 8 is supported, which is the current lts. It is however possible to write our own promisify (or use an existing one to support node 6).It will support node 6