Skip to content

Conversation

@andrewkmin
Copy link
Contributor

@andrewkmin andrewkmin commented Jun 9, 2025

Summary & Motivation (Problem vs. Solution)

$title

How I Tested These Changes

Pre merge check list

  • Update CHANGELOG.MD

@andrewkmin andrewkmin requested a review from a team as a code owner June 9, 2025 23:34
"tokio-runtime",

hickory-resolver = { version = "0.25.1", features = [
"tokio",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cr-tk
Copy link
Collaborator

cr-tk commented Jun 10, 2025

@andrewkmin the CI shows some failing tests, apparently due to API/namespace changes in hickory, so I think going to 0.25.x requires some code changes as well.

Based on the 0.25.0 changelog, they made a lot of changes in the new minor version. The README suggests they try to follow SemVer, but it seems that in this case they didn't.

I've noticed that you're switching to hickory-resolver 0.25.1 even though 0.25.2 is available. Does this have a specific reason, could we bump this further?

@cr-tk
Copy link
Collaborator

cr-tk commented Jun 17, 2025

@andrewkmin as discussed internally, I've created #554 to adopt our code to the new API changes and do some other hickory-resolver related improvements we had planned.

It's a superset of #538, so I'm closing this PR here.

@cr-tk cr-tk closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants