Update the rand crate in qos_net #555
Merged
+103
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-n-o
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
A recent Trail of Bits audit on
qos_netrecommended that we update to the newestrandbranch as a maintenance measure.With the
rand0.8.x->0.9.xstep, the API has changed a bit, requiring code changes. This PR focuses on theqos_netcrate, and intentionally leaves conversions of other QOS components to followup PRs.The expected code behavior should be identical.
Note to dependency security reviewers: we essentially trust all relevant new crate versions already, except for the
getrandomswitch to0.3.3. I reviewed this over in #554 . Internal review documentation is available for both PRs.I approve of this PR as a dependency reviewer.
How I Tested These Changes
Local tests.
Pre merge check list