parse_tldrlist: propagate opendir fails instead of segfaulting #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
reviewed
Jan 6, 2022
I've been hesitant to do this, because we don't do it anywhere else. According to Apple's man page `opendir` doesn't set `errno`, so no further info.
MasterOdin
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Return 1, when
opendirfails.Why the change?
Fixes segfaults.
How can this be tested?
Reproduce #71, or
chown root:root ~/.tldrc && chmod 700 ~/.tldrc.Relevant tickets?
While not fixing it, this does stop #71 from segfaulting.