Various fixes and improvements to fish shell completion

[superatomic]

What does it do?

This pull request fixes a fatal bug in the fish shell autocompletion that caused it to crash with a syntax error.
It also makes improvements to the functionality of the fish shell autocompletion. Fixes #87.

Functionality before these changes:

$ tldr [TAB]complete: Completion 'tailscale unar ipaggcreate mupdf vimtutor doctl-balance head swift alex lpstat git-show-unmerged-branches particle doxygen bootctl go-version virsh-pool-delete d8 pdflatex pssh pkill jp2a git-clear-soft rtl_sdr swipl jigsaw iperf az-storage-entity docker-ps arp exiv2 cmp dexdump git-release odps mlr mysqld deluge-console puppet-apply git-contrib mongoimport ps dotnet-tool nu stow dolt-clone pdffonts http az-login git-sizer mkvmerge circo fc-match gdrive pio-check aws-secretsmanager jhsdb rails-destroy sendmail [ pueue-completions pnpx zoxide mycli goreload stat az-feedback z sshpass hg-clone runit cosign sops pio-ci svgo stack montage mocha jtbl tr nm httprobe qtcreator slimrb consul-kv pueue-shutdown bundletool-validate pretty-bytes gh-mintty blackfire conda-create gpg-zip eva vimdiff last sccmap gcc exiftool cradle-elastic django-admin puppet ranger spfquery xkcdpass pycodestyle docker-machine gist ulimit git-filter-repo buku vue-init zless zola git-graft minisign keychain hunspell docker-inspect newman az-storage trawl fly psql joe kotlin pueue-follow ping6 sleep cola newsboat find gox license git-pull nvim ogrmerge.py rails spark firebase pio-home gdb git-reset k8sec gh-secret hostapd docker-commit az-network kube-capacity make hg-remove f3fix phive git-bugreport case strip-nondeterminism forever pgbench pickle peludna-prognoza lzop git-gc assimp pueue-send xdelta complete diff virsh-connect pueue-restart speedtest runsvchdir bower git-abort yq scan-build obs netlify grunt chsh atq viu passwd cvs ar wrk az-storage-blob pdfinfo nvm.fish whois steamcmd twm mu git-diff-files tpp react-native drill envoy ansible-vault googler git-symbolic-ref wrangler magick nice mullvad vim var-dump-server dvc-diff husky sk jmap mmv gacutil az-appconfig cbonsai basename mdp zm unlink ngs touch doctl-account nativefier scalafmt skicka go factor tlmgr-arch gobuster zpool repren rclone git-update-ref go-vet brotli monodis bzgrep git-imerge 2to3 az-config npm-home llvm-g++ delta iex git-rename-branch ipfs pic dog nload grpcurl clockwork-cli git-reset-file python trans ldapsearch xml-edit maza zsteg [[ gpg consul mmdc whoami git-var git-fame virsh-pool-list hive shellcheck git-range-diff cloc peco hg-branch indent docker-save az-logout nmap dolt-commit git-stash more dua php-yii colorls calendar git-count-objects wapm ctest sox hsd-cli iotop phan phing xml-transform sc-im virsh-pool-start svgr git-rev-list notmuch ocamlfind ionice git-show emacs declare csvstat mosquitto_pub duplicacy chromium pinta flake8 etcd socat gitlint zip calibredb clang-cpp spike zfs pueue-pause bw pv xh jobs xplr runsv smartctl git-checkout daps llvm-gcc mongodump mkdir unclutter cdk hg-commit lt dolt-branch popd lambo docker-stats rr xml-pyx msbuild pushd logstash doctl-auth wat2wasm jq aws-quicksight xml-format airmon-ng subl git-commit-graph dvc-freeze tslint vala nano git-difftool phpcpd while git-rev-parse thunderbird composer-require-checker nasm bosh pwd x_x chezmoi tlmgr-install ipcs git-repack swc nix-env geth uniq false lmms gradle gh-api virsh-pool-define-as ghci acme.sh-dns git-daemon rustc kompose guacd git-column magento split okular kill gpg-tui glab-issue gitmoji git-rename-remote grip transcrypt mkfifo openssl-s_client glab-mr go-generate git-worktree pueue-group pueue-edit kubens vault uvicorn ipython git-cherry-pick docker-network tlmgr-candidates rubocop chars mozillavpn git-sync keybase gatsby lwp-request uncrustify cotton meson trivy git-notes 7zr apm git-ls-tree qutebrowser git-shortlog fuck nop pr javac vue-serve gnucash-cli astronomer babel pueue recsel asar img2pdf act aws-glue csvsql sv wasm2c netstat terragrunt tmpmail sublist3r nimble lolcat git-status starship-init comby deluge shift gunicorn xgettext gh-workflow satis decaffeinate view x11docker todoist distccd tbl virsh-pool-autostart vladimyr gopass cpio kubectl-logs qr neato nl ts git-check-ref-format oathtool pathchk trap sn zek pageres lp sha256sum psysh nim g++ git-missing yarn pax git-request-pull darkhttpd fdupes tcpdump ts-node autossh elixir amass-enum nginx ghdl p7zip minifab heroku git-brv testssl scc xml-unescape git-commit-tree fkill file glances sshd dig gh-auth pixiecore pdftex clojure qdbus b2sum glab-auth xetex banner scrapy xargs expand gtop kops mongorestore strings restic git-subtree fluxctl adb goimports virsh-list sshuttle virt-sysprep progpilot protector xxd pyenv you-get minetestserver uptime ykman mogrify fakedata gitlab-ctl scheme m4 aws-iam transmission-cli ss-local adb-shell eqn pg_restore xcaddy direnv borg rector watchexec qemu git-whatchanged mutt fish ksh crunch bshell pio-team scp pdftk gotty compare standard-version dotnet fc-pattern atoum git-fetch git-revert jetifier transfersh caddy mh_metric openscad sup r2 zbarimg traceroute steam grumphp rvm atom fastlane srm py-spy sfdp st-util cradle-deploy git-ls-files doctum parallel-lint deemix docker-login fls source git-for-each-repo tuir surfraw git-effort todoman pio-test phpcs ftp bastet dvc-unfreeze shards mpg321 virsh 7za timetrap tox xml-canonic tailscale-file date mosquitto locust llvm-config git-instaweb popeye zig mc zmore tac radare2 ignite swig pio-platform hg-update git-delete-tag dvc-fetch reflac go-tool omf go-env virt-sparsify nvidia-smi sdkmanager git-verify-commit echo ng pueue-log diffstat omz scala wget ogr2ogr zipgrep hostid if gxl2gv finger nkf virtualenvwrapper next cd sponge git-annex cmark git-ignore vue bandwhich odps-resource oc croc dolt-blame history expr jupyter redis-server stolonctl fin cryfs mscore dillo lebab grex git-tag read autopep8 nslookup git-cp mysql qrencode sonar-scanner fping bmaptool leave mutagen git-merge velero git-obliterate seq xml-validate docker-slim git-flow jwt ping badblocks pueue-switch typeset doctl-apps clifm virsh-pool-build glab-mr-merge lambo-new git-credential aws-ses vue-build autoflake zcat git-show-merged-branches cwebp asciinema nokogiri kdig sbt avrdude git-rm llvm-objdump az-account git-secret helm odps-func xml-escape arduino dvc-destroy kubectl column watson hostname solcjs nc multipass apropos clang git-checkout-index git-check-mailmap aws-vault pio-boards func symfony mh_copyright virtualenv ghcup ctags pueue-add nudoku git-grep fold php-artisan puppet-agent brew wpa_supplicant plesk makensis git-ls-remote fusermount cheat f3probe git-clean rustfmt umask less xml-list coffee redis-cli json5 fd phpstan cpdf glab-release k8s-unused-secret-detector optipng is-up evil-winrm az-lock hexyl compgen phpstorm eval egrep jc gh-extension shred progress clamdscan xpdf ifconfig md5sum uudecode bison wondershaper ssh fdp pio-project sindresorhus pppd fio aws-help git-am luac llvm-bcanalyzer ebook-convert html5validator git-verify-tag ioping waitress-serve rbt cradle-install hping moro dot sequelize sum git-fork rdfind multitail keepassxc-cli sftp git-format-patch amass gixy histexpand pipx shopt csvtool packtpub etcdctl jmtpfs feh asciidoctor pip node kitty php surge fc-list watch showfigfonts aws-rds xkill deno git-alias platformio yacas git-reauthor fswebcam from prosodyctl hg-pull csvformat dict smbmap docker-exec sdcv for diffoscope docker-image git-mr betty install dolt-checkout rails-db git-mergetool docker-system meteor mount openttd highlight ansible-playbook tailscale-up helm-install bashmarks tye dolt-config rtmpdump guile gulp git-create-branch xz lighthouse npx enscript ned pio-account hg ivpn pipenv ex numfmt virsh-undefine stdbuf apg pip3 latex go-run virt-install mix git-show-ref julia hexdump robo ed kubectl-get paste zstd webtorrent flex aws-s3 dotnet-build npm-why mp3info pyenv-virtualenv swagger-codegen emacsclient brew-cask lb osage info acme.sh ogrinfo hadolint gcal xephyr mpc psgrep zopflipng dvc-init unalias racket electrum ansible-pull git-show-branch elm antibody set stripe glab-pipeline dvc-gc rbenv todo mmls terminalizer nf-core gh-release gow kitex orca-c hyperfine drush phpspec inkscape go-bug lynx script virt-clone pio-settings yt-dlp laravel mongoexport chroma git-check-attr cups-config promtool git-ignore-io git-mv pactl parallel adb-install tokei lldb cargo-rustc gdu monodevelop base32 ssh-add wormhole streamlink gh-reference gnomon gem pueue-remove realpath apktool astyle yesod unrar which runsvdir lpinfo lorem openssl-ts identify ghost q searchsploit gource wasm-objdump git-show-index alacritty gofmt arc web-ext figlet gh-issue vlc sd go-fmt gh-codespace ganache-cli tsc git-clear ansible-galaxy paci dd corepack sqlite3 roll moe git-repl expose groff exit logname behat dune cf mitmdump fastmod offlineimap fg git-undo mpd in-toto-sign gh-browse az warp-cli id rustup kubectl-rollout openssl-req 7z nix docker-container lumen resume git-remote chgrp rc odps-inst speedcrunch git-delete-branch tldr-lint n loc pve-firewall arp-scan safe clang-format jps dcfldd most micro git-stage firefox mosquitto_passwd mutool docker-build sdk tabula ajson balena erl linkchecker go-list pfetch gcalcli exenv pueue-help pueue-enqueue pg_ctl transmission-remote dirsearch units kubetail pprof git-cat-file ocamlc hg-root go-mod tlmgr-update haxelib doctl-compute-droplet env hardhat phpbu pio-org nikto colordiff git-describe kosmorro az-term qcp vcsh hg-log git-add jupytext youtube-viewer gh-alias bedtools vercel ocaml sha384sum imapsync tlmgr-shell base64 terraform irssi graphml2gv sails fselect semver autojump csslint pio-debug mingle curl google-chrome tmuxinator kubeadm travis asdf pass phpize gh-screensaver gvpack xml-select tty esbuild command ab git-diff dc roave-backward-compatibility-check sdiff go-get git-cola pio-run tlmgr-platform docker-swarm gh-pr-merge fortune scrcpy choose dotnet-publish tred bfg kubectl-run alias ufraw-batch sha1sum true zdb rg emulator llvm-dis glow entr tlmgr initdb fossa bssh az-pipelines docker-service odps-tunnel encfs rekor-cli ical rsstail rabin2 tb fc wasm2wat meld screenfetch cabal users wpscan mktemp flutter llc phpdox mongo awslogs tig masscan cowsay ffsend volta p4 jar nodemon nix-collect-garbage bvnc lz4 supervisorctl fisher gh-gist gdalbuildvrt tcsh meshlabserver kotlinc plantuml molecule pio-package pre-commit git-archive kak ionic stern xml-elements uuencode svn calibre-server pdf-parser ffprobe clear ssh-copy-id git-log vectorize-pixelart write mysqldump hg-add pio atrm comm piodebuggdb php-coveralls ngrok tlmgr-path jello miniserve chmod git-authors mitmproxy xidel fnm ssh-agent hexo fdroid dwebp hg-init mosh rev nomad shasum gh-repo laravel-zero colorpicker kahlan reflex hg-serve gh-environment git-lock tex fc-cache git-commits-since cmatrix pdftocairo pwsh r git-delete-merged-branches rcat openssl-genpkey jstack fdroidcl tlmgr-backup git-svn dotnet-restore espeak yarn-why rapper aws-lambda raco mediainfo gmssl tea errno gunzip java ffplay nohup plenv age telnet stty bundle home-manager peerflix od kdeconnect-cli picard cradle-package subliminal time loadtest gpg2 javadoc gh-completion flac clementine monop gh-config ia tesseract bundler dep middleman react-native-start drupal keepass2 p5 ngrep terraform-plan qmv handbrakecli stl2gts az-vm pio-lib pdfgrep tlmgr-info minetest aws-kinesis amass-viz buzzphrase import kiwi-ng bitcoin-cli odps-auth beanstalkd redshift carp git-commit dlv ohdear-cli cppclean rsync dvc-dag duplicity wasm-opt csvcut patch browser-sync kubectl-delete tldr mailx csvpy ect mail speedtest-cli jrnl git-cherry az-tag jekyll weasyprint jhat zipalign exercism screen wuzz conan-frogarian dvc-checkout ibmcloud vegeta speed-test in-toto-record jadx timidity link bc godot sync jpegoptim s git-branch lua cppcheck openssl-genrsa topydo ocrmypdf df hello pueue-clean serverless pio-system ag pdfunite lsd nextflow maestral interdiff gh-run takeout box nx mkcert ninja az-bicep opusenc berks twopi lein virsh-domblklist pyflakes syncthing tee pnpm wc pdfjoin starship conan vela gh-pr kube-fzf aria2 crystal rbac-lookup git-clone elvish troff jenv id3tag salt-run git-squash k6 nbtscan git-changelog aws-ecr git-summary git-check-ignore jest ncmpcpp virsh-help pigz git xprop fmt aapt skaffold rar tlmgr-paper clamscan pio-update unison hg-push yapf cronic csvclean whereis tail pdfjam live-server pup git-submodule phpunit hg-status idnits mh_lint axel arping carbon-now mate-dictionary dirs help2man git-bug openssl git-count kind unexpand amass-track pylint docker-compose circup pueue-parallel install-tl rtv valac tsort task knife git-pr gocryptfs mktorrent abduco uname nix-build singularity mesg tlmgr-option dvc-config updog gh-cs upx truncate ansible ncc convmv csc espanso gops git-apply u3d kafkacat pass-otp vsce pwgen umount lex w docker-logs git-switch gzip rscript black chisel arduino-builder iperf3 tree minikube python3 bg timew git-restore vzdump httpry gml2gv yank iconv ffe grep pueue-kill makepasswd git-extras dircolors rmdir hping3 killall gibo couchdb llvm-cat piactl glab-alias git-rebase avo dart git-locked glab hydra xxh llvm-strings ember vdir go-doc electron-packager aws-s3api now flow rspec godoc llvm-ar matlab sass go-fix dexter openssl-x509 ruby yes serve csh ffmpeg solo svgcleaner josm xml printf git-browse acyclic wpm nth ant agate codespell ack mpv in-toto-run visudo zeek paperkey dolt-add kubectl-describe nrm wp topgrade pdfimages nms httping arch hn csvsort git-push phpcbf git-blame-someone-else code core-validate-commit cordova dfc go-build ccomps timeout blockout2 dhclient git-bundle salt-call ybacklight parquet-tools exrex mplayer makebuildserver noti ledger tlmgr-gui fgrep gh-pr-create openssl-dgst phpmd rails-routes dumpcap pueue-status ssh-keyscan msmtp pdftotext qemu-img protoc jdupes virsh-pool-info pio-access fastboot glab-mr-create auditd amass-db ghc git-lfs secrethub gpgv git-show-tree nm-classic gifsicle hub packer xo pygmentize spatial mat2 npm docker mcs hakyll-init git-update-index createdb androguard aws xsv hr rm dash zsh clj gnucash kubectx du lilypond xml-depyx lli join security-checker kustomize mosquitto_sub st-info fast git-stripspace doas at vagrant su w3m light-arionum-cli pngcheck ptargrep traefik opt play git-coauthor aws-ec2 llvm-nm siege inkview logger opam openvpn export wal git-unlock groups typeorm awk xmllint termdown dvc-add john bat gcloud jcal mk neomutt zellij docker-images warp-diag ls dolt xev adscript git-replace zmv infection iverilog test tlmgr-remove git-setup github-label-sync cp bup ntl csvlook go-test gimp youtube-dl cargo-doc shiori gh-secret-set mm2gv pueue-reset hashid c99 chroot turbo st-flash docker-cp dive bundletool rich copyq ansible-inventory cradle-sql virsh-pool-destroy gitk blender type ykinfo pastel git-reflog objdump musescore kaggle lpass pest webstorm xonsh gh-formatting pngcrush pandoc p10k git-standup gvcolor cupsd gh-ssh-key cargo-build git-blame nix-shell docker-run shc git-init eslint rails-generate prettier podman dvc ibmcloud-login zipinfo gv2gml exa go-clean perl mtr exec conda in2csv bq lpr drupal-check git-sed cradle glab-repo git-mailinfo textql mvn pinky brew-bundle sort npm-check man cargo-clippy mr dotnet-ef msfvenom cat git-rename-tag npm-name samtools sha224sum tar pvecm sbcl sphinx-build mytop standard openssl-prime dirname local hsw-cli terraform-fmt printenv mp4box jhipster airpaste gh dhcpwn enca pio-upgrade glib-compile-resources host virsh-pool-undefine stormlock gh-issue-create ansible-doc git-maintenance jarsigner wordgrinder git-config aws-cur sl sudo cmake aria2c sqlmap unzip pm2 pamixer git-help ipsumdump pdfposter edgepaint shuf git-info boot smalltalkci r2e salt-key sed amass-intel mixxx pueue-stash ipaggmanip cargo-test go-install ncdu xmlto unflatten dokku elinks gh-help envsubst csvgrep pio-init texdoc dcg rga openconnect composer gitlab guetzli docker-secret wait phploc deluged mongod truffle detox dvc-commit http-server-upload sha512sum tldrl khal quota pg_dumpall pg_dump transcode docker-rmi readlink pgrep duc gitlab-runner nproc tmux qpdf bash aws-google-auth cake ocamlopt sqsc chown supervisord inkmake nodenv helix git-send-email phpenv nvm psalm docker-volume ln pio-device pio-remote git-annotate renice dcode route hostess htop webpack rbash cut gt gitsome pveperf trash-cli pt llvm-as zlib-flate ansiweather adguardhome mv tput xar git-archive-file transmission-create sshfs texliveonfly sh httpflow htpasswd git-delta who dust batch vi lerna influx cloudflared svn-changelist neofetch f3read hugo vboxmanage csvkit valgrind diff-pdf bzip2 lsof docker-start snyk btm xcv adb-reverse latexmk http-server pip-install pypy cksum git-fsck diskonaut quilt odps-table salt kate convert gv2gxl where git-prune ssh-keygen tlmgr-check pip-uninstall rainbowstream pueue-start crontab clang-tidy gnuplot postcss poetry fswatch subfinder clang++ hangups git-touch flask git-root pdfseparate patchwork slackcat git-local-commits grap sslscan git-bisect theharvester bundletool-dump bcomps fzf f3write cargo head reboot system_profiler bless pmset open airportd stat sntpd spctl universalaccessd defaults textutil secd xattr mdfind machine indent networkquality as chflags xml2man whatis split diskutil dot_clean notifyd usernoted filecoordinationd afplay xcrun securityd uptime automountd wacaw date coreauthd archey ping launchctl sips md5 opensnoop m bnepd systemsetup fsck sysctl carthage launchd scutil nvram dark-mode emond coreautha spotify whence imgcat nettop lldb hdiutil apachectl brightness dd lipo vpnd dmesg qlmanage base64 yabai caffeinate pbcopy fileicon xsltproc shortcuts log xed rename plutil ditto afinfo wifi-password uuidgen softwareupdate mkfile cloudphotod pkgutil bc ocspd csrutil port sw_vers photoanalysisd yaa coreaudiod wc pbpaste avbdeviced tail timed uname xctool w tmutil istats mdls shutdown nfcd mas distnoted arch applecamerad pod sdef xcode-select safeejectgpu screencapture du networksetup top csshx asr mdutil cfprefsd xcodebuild fdesetup photolibraryd airport getfileinfo xip cal icalbuddy shuf appsleepd sed valet readlink look bird drutil codesign route security locate duti osascript say' contained a syntax error
complete: Expected a string, but found an incomplete token
tailscale unar ipaggcreate mupdf vimtutor doctl-balance head swift alex lpstat git-show-unmerged-branches particle doxygen bootctl go-version virsh-pool-delete d8 pdflatex pssh pkill jp2a git-clear-soft rtl_sdr swipl jigsaw iperf az-storage-entity docker-ps arp exiv2 cmp dexdump git-release odps mlr mysqld deluge-console puppet-apply git-contrib mongoimport ps dotnet-tool nu stow dolt-clone pdffonts http az-login git-sizer mkvmerge circo fc-match gdrive pio-check aws-secretsmanager jhsdb rails-destroy sendmail [ pueue-completions pnpx zoxide mycli goreload stat az-feedback z sshpass hg-clone runit cosign sops pio-ci svgo stack montage mocha jtbl tr nm httprobe qtcreator slimrb consul-kv pueue-shutdown bundletool-validate pretty-bytes gh-mintty blackfire conda-create gpg-zip eva vimdiff last sccmap gcc exiftool cradle-elastic django-admin puppet ranger spfquery xkcdpass pycodestyle docker-machine gist ulimit git-filter-repo buku vue-init zless zola git-graft minisign keychain hunspell docker-inspect newman az-storage trawl fly psql joe kotlin pueue-follow ping6 sleep cola newsboat find gox license git-pull nvim ogrmerge.py rails spark firebase pio-home gdb git-reset k8sec gh-secret hostapd docker-commit az-network kube-capacity make hg-remove f3fix phive git-bugreport case strip-nondeterminism forever pgbench pickle peludna-prognoza lzop git-gc assimp pueue-send xdelta complete diff virsh-connect pueue-restart speedtest runsvchdir bower git-abort yq scan-build obs netlify grunt chsh atq viu passwd cvs ar wrk az-storage-blob pdfinfo nvm.fish whois steamcmd twm mu git-diff-files tpp react-native drill envoy ansible-vault googler git-symbolic-ref wrangler magick nice mullvad vim var-dump-server dvc-diff husky sk jmap mmv gacutil az-appconfig cbonsai basename mdp zm unlink ngs touch doctl-account nativefier scalafmt skicka go factor tlmgr-arch gobuster zpool repren rclone git-update-ref go-vet brotli monodis bzgrep git-imerge 2to3 az-config npm-home llvm-g++ delta iex git-rename-branch ipfs pic dog nload grpcurl clockwork-cli git-reset-file python trans ldapsearch xml-edit maza zsteg [[ gpg consul mmdc whoami git-var git-fame virsh-pool-list hive shellcheck git-range-diff cloc peco hg-branch indent docker-save az-logout nmap dolt-commit git-stash more dua php-yii colorls calendar git-count-objects wapm ctest sox hsd-cli iotop phan phing xml-transform sc-im virsh-pool-start svgr git-rev-list notmuch ocamlfind ionice git-show emacs declare csvstat mosquitto_pub duplicacy chromium pinta flake8 etcd socat gitlint zip calibredb clang-cpp spike zfs pueue-pause bw pv xh jobs xplr runsv smartctl git-checkout daps llvm-gcc mongodump mkdir unclutter cdk hg-commit lt dolt-branch popd lambo docker-stats rr xml-pyx msbuild pushd logstash doctl-auth wat2wasm jq aws-quicksight xml-format airmon-ng subl git-commit-graph dvc-freeze tslint vala nano git-difftool phpcpd while git-rev-parse thunderbird composer-require-checker nasm bosh pwd x_x chezmoi tlmgr-install ipcs git-repack swc nix-env geth uniq false lmms gradle gh-api virsh-pool-define-as ghci acme.sh-dns git-daemon rustc kompose guacd git-column magento split okular kill gpg-tui glab-issue gitmoji git-rename-remote grip transcrypt mkfifo openssl-s_client glab-mr go-generate git-worktree pueue-group pueue-edit kubens vault uvicorn ipython git-cherry-pick docker-network tlmgr-candidates rubocop chars mozillavpn git-sync keybase gatsby lwp-request uncrustify cotton meson trivy git-notes 7zr apm git-ls-tree qutebrowser git-shortlog fuck nop pr javac vue-serve gnucash-cli astronomer babel pueue recsel asar img2pdf act aws-glue csvsql sv wasm2c netstat terragrunt tmpmail sublist3r nimble lolcat git-status starship-init comby deluge shift gunicorn xgettext gh-workflow satis decaffeinate view x11docker todoist distccd tbl virsh-pool-autostart vladimyr gopass cpio kubectl-logs qr neato nl ts git-check-ref-format oathtool pathchk trap sn zek pageres lp sha256sum psysh nim g++ git-missing yarn pax git-request-pull darkhttpd fdupes tcpdump ts-node autossh elixir amass-enum nginx ghdl p7zip minifab heroku git-brv testssl scc xml-unescape git-commit-tree fkill file glances sshd dig gh-auth pixiecore pdftex clojure qdbus b2sum glab-auth xetex banner scrapy xargs expand gtop kops mongorestore strings restic git-subtree fluxctl adb goimports virsh-list sshuttle virt-sysprep progpilot protector xxd pyenv you-get minetestserver uptime ykman mogrify fakedata gitlab-ctl scheme m4 aws-iam transmission-cli ss-local adb-shell eqn pg_restore xcaddy direnv borg rector watchexec qemu git-whatchanged mutt fish ksh crunch bshell pio-team scp pdftk gotty compare standard-version dotnet fc-pattern atoum git-fetch git-revert jetifier transfersh caddy mh_metric openscad sup r2 zbarimg traceroute steam grumphp rvm atom fastlane srm py-spy sfdp st-util cradle-deploy git-ls-files doctum parallel-lint deemix docker-login fls source git-for-each-repo tuir surfraw git-effort todoman pio-test phpcs ftp bastet dvc-unfreeze shards mpg321 virsh 7za timetrap tox xml-canonic tailscale-file date mosquitto locust llvm-config git-instaweb popeye zig mc zmore tac radare2 ignite swig pio-platform hg-update git-delete-tag dvc-fetch reflac go-tool omf go-env virt-sparsify nvidia-smi sdkmanager git-verify-commit echo ng pueue-log diffstat omz scala wget ogr2ogr zipgrep hostid if gxl2gv finger nkf virtualenvwrapper next cd sponge git-annex cmark git-ignore vue bandwhich odps-resource oc croc dolt-blame history expr jupyter redis-server stolonctl fin cryfs mscore dillo lebab grex git-tag read autopep8 nslookup git-cp mysql qrencode sonar-scanner fping bmaptool leave mutagen git-merge velero git-obliterate seq xml-validate docker-slim git-flow jwt ping badblocks pueue-switch typeset doctl-apps clifm virsh-pool-build glab-mr-merge lambo-new git-credential aws-ses vue-build autoflake zcat git-show-merged-branches cwebp asciinema nokogiri kdig sbt avrdude git-rm llvm-objdump az-account git-secret helm odps-func xml-escape arduino dvc-destroy kubectl column watson hostname solcjs nc multipass apropos clang git-checkout-index git-check-mailmap aws-vault pio-boards func symfony mh_copyright virtualenv ghcup ctags pueue-add nudoku git-grep fold php-artisan puppet-agent brew wpa_supplicant plesk makensis git-ls-remote fusermount cheat f3probe git-clean rustfmt umask less xml-list coffee redis-cli json5 fd phpstan cpdf glab-release k8s-unused-secret-detector optipng is-up evil-winrm az-lock hexyl compgen phpstorm eval egrep jc gh-extension shred progress clamdscan xpdf ifconfig md5sum uudecode bison wondershaper ssh fdp pio-project sindresorhus pppd fio aws-help git-am luac llvm-bcanalyzer ebook-convert html5validator git-verify-tag ioping waitress-serve rbt cradle-install hping moro dot sequelize sum git-fork rdfind multitail keepassxc-cli sftp git-format-patch amass gixy histexpand pipx shopt csvtool packtpub etcdctl jmtpfs feh asciidoctor pip node kitty php surge fc-list watch showfigfonts aws-rds xkill deno git-alias platformio yacas git-reauthor fswebcam from prosodyctl hg-pull csvformat dict smbmap docker-exec sdcv for diffoscope docker-image git-mr betty install dolt-checkout rails-db git-mergetool docker-system meteor mount openttd highlight ansible-playbook tailscale-up helm-install bashmarks tye dolt-config rtmpdump guile gulp git-create-branch xz lighthouse npx enscript ned pio-account hg ivpn pipenv ex numfmt virsh-undefine stdbuf apg pip3 latex go-run virt-install mix git-show-ref julia hexdump robo ed kubectl-get paste zstd webtorrent flex aws-s3 dotnet-build npm-why mp3info pyenv-virtualenv swagger-codegen emacsclient brew-cask lb osage info acme.sh ogrinfo hadolint gcal xephyr mpc psgrep zopflipng dvc-init unalias racket electrum ansible-pull git-show-branch elm antibody set stripe glab-pipeline dvc-gc rbenv todo mmls terminalizer nf-core gh-release gow kitex orca-c hyperfine drush phpspec inkscape go-bug lynx script virt-clone pio-settings yt-dlp laravel mongoexport chroma git-check-attr cups-config promtool git-ignore-io git-mv pactl parallel adb-install tokei lldb cargo-rustc gdu monodevelop base32 ssh-add wormhole streamlink gh-reference gnomon gem pueue-remove realpath apktool astyle yesod unrar which runsvdir lpinfo lorem openssl-ts identify ghost q searchsploit gource wasm-objdump git-show-index alacritty gofmt arc web-ext figlet gh-issue vlc sd go-fmt gh-codespace ganache-cli tsc git-clear ansible-galaxy paci dd corepack sqlite3 roll moe git-repl expose groff exit logname behat dune cf mitmdump fastmod offlineimap fg git-undo mpd in-toto-sign gh-browse az warp-cli id rustup kubectl-rollout openssl-req 7z nix docker-container lumen resume git-remote chgrp rc odps-inst speedcrunch git-delete-branch tldr-lint n loc pve-firewall arp-scan safe clang-format jps dcfldd most micro git-stage firefox mosquitto_passwd mutool docker-build sdk tabula ajson balena erl linkchecker go-list pfetch gcalcli exenv pueue-help pueue-enqueue pg_ctl transmission-remote dirsearch units kubetail pprof git-cat-file ocamlc hg-root go-mod tlmgr-update haxelib doctl-compute-droplet env hardhat phpbu pio-org nikto colordiff git-describe kosmorro az-term qcp vcsh hg-log git-add jupytext youtube-viewer gh-alias bedtools vercel ocaml sha384sum imapsync tlmgr-shell base64 terraform irssi graphml2gv sails fselect semver autojump csslint pio-debug mingle curl google-chrome tmuxinator kubeadm travis asdf pass phpize gh-screensaver gvpack xml-select tty esbuild command ab git-diff dc roave-backward-compatibility-check sdiff go-get git-cola pio-run tlmgr-platform docker-swarm gh-pr-merge fortune scrcpy choose dotnet-publish tred bfg kubectl-run alias ufraw-batch sha1sum true zdb rg emulator llvm-dis glow entr tlmgr initdb fossa bssh az-pipelines docker-service odps-tunnel encfs rekor-cli ical rsstail rabin2 tb fc wasm2wat meld screenfetch cabal users wpscan mktemp flutter llc phpdox mongo awslogs tig masscan cowsay ffsend volta p4 jar nodemon nix-collect-garbage bvnc lz4 supervisorctl fisher gh-gist gdalbuildvrt tcsh meshlabserver kotlinc plantuml molecule pio-package pre-commit git-archive kak ionic stern xml-elements uuencode svn calibre-server pdf-parser ffprobe clear ssh-copy-id git-log vectorize-pixelart write mysqldump hg-add pio atrm comm piodebuggdb php-coveralls ngrok tlmgr-path jello miniserve chmod git-authors mitmproxy xidel fnm ssh-agent hexo fdroid dwebp hg-init mosh rev nomad shasum gh-repo laravel-zero colorpicker kahlan reflex hg-serve gh-environment git-lock tex fc-cache git-commits-since cmatrix pdftocairo pwsh r git-delete-merged-branches rcat openssl-genpkey jstack fdroidcl tlmgr-backup git-svn dotnet-restore espeak yarn-why rapper aws-lambda raco mediainfo gmssl tea errno gunzip java ffplay nohup plenv age telnet stty bundle home-manager peerflix od kdeconnect-cli picard cradle-package subliminal time loadtest gpg2 javadoc gh-completion flac clementine monop gh-config ia tesseract bundler dep middleman react-native-start drupal keepass2 p5 ngrep terraform-plan qmv handbrakecli stl2gts az-vm pio-lib pdfgrep tlmgr-info minetest aws-kinesis amass-viz buzzphrase import kiwi-ng bitcoin-cli odps-auth beanstalkd redshift carp git-commit dlv ohdear-cli cppclean rsync dvc-dag duplicity wasm-opt csvcut patch browser-sync kubectl-delete tldr mailx csvpy ect mail speedtest-cli jrnl git-cherry az-tag jekyll weasyprint jhat zipalign exercism screen wuzz conan-frogarian dvc-checkout ibmcloud vegeta speed-test in-toto-record jadx timidity link bc godot sync jpegoptim s git-branch lua cppcheck openssl-genrsa topydo ocrmypdf df hello pueue-clean serverless pio-system ag pdfunite lsd nextflow maestral interdiff gh-run takeout box nx mkcert ninja az-bicep opusenc berks twopi lein virsh-domblklist pyflakes syncthing tee pnpm wc pdfjoin starship conan vela gh-pr kube-fzf aria2 crystal rbac-lookup git-clone elvish troff jenv id3tag salt-run git-squash k6 nbtscan git-changelog aws-ecr git-summary git-check-ignore jest ncmpcpp virsh-help pigz git xprop fmt aapt skaffold rar tlmgr-paper clamscan pio-update unison hg-push yapf cronic csvclean whereis tail pdfjam live-server pup git-submodule phpunit hg-status idnits mh_lint axel arping carbon-now mate-dictionary dirs help2man git-bug openssl git-count kind unexpand amass-track pylint docker-compose circup pueue-parallel install-tl rtv valac tsort task knife git-pr gocryptfs mktorrent abduco uname nix-build singularity mesg tlmgr-option dvc-config updog gh-cs upx truncate ansible ncc convmv csc espanso gops git-apply u3d kafkacat pass-otp vsce pwgen umount lex w docker-logs git-switch gzip rscript black chisel arduino-builder iperf3 tree minikube python3 bg timew git-restore vzdump httpry gml2gv yank iconv ffe grep pueue-kill makepasswd git-extras dircolors rmdir hping3 killall gibo couchdb llvm-cat piactl glab-alias git-rebase avo dart git-locked glab hydra xxh llvm-strings ember vdir go-doc electron-packager aws-s3api now flow rspec godoc llvm-ar matlab sass go-fix dexter openssl-x509 ruby yes serve csh ffmpeg solo svgcleaner josm xml printf git-browse acyclic wpm nth ant agate codespell ack mpv in-toto-run visudo zeek paperkey dolt-add kubectl-describe nrm wp topgrade pdfimages nms httping arch hn csvsort git-push phpcbf git-blame-someone-else code core-validate-commit cordova dfc go-build ccomps timeout blockout2 dhclient git-bundle salt-call ybacklight parquet-tools exrex mplayer makebuildserver noti ledger tlmgr-gui fgrep gh-pr-create openssl-dgst phpmd rails-routes dumpcap pueue-status ssh-keyscan msmtp pdftotext qemu-img protoc jdupes virsh-pool-info pio-access fastboot glab-mr-create auditd amass-db ghc git-lfs secrethub gpgv git-show-tree nm-classic gifsicle hub packer xo pygmentize spatial mat2 npm docker mcs hakyll-init git-update-index createdb androguard aws xsv hr rm dash zsh clj gnucash kubectx du lilypond xml-depyx lli join security-checker kustomize mosquitto_sub st-info fast git-stripspace doas at vagrant su w3m light-arionum-cli pngcheck ptargrep traefik opt play git-coauthor aws-ec2 llvm-nm siege inkview logger opam openvpn export wal git-unlock groups typeorm awk xmllint termdown dvc-add john bat gcloud jcal mk neomutt zellij docker-images warp-diag ls dolt xev adscript git-replace zmv infection iverilog test tlmgr-remove git-setup github-label-sync cp bup ntl csvlook go-test gimp youtube-dl cargo-doc shiori gh-secret-set mm2gv pueue-reset hashid c99 chroot turbo st-flash docker-cp dive bundletool rich copyq ansible-inventory cradle-sql virsh-pool-destroy gitk blender type ykinfo pastel git-reflog objdump musescore kaggle lpass pest webstorm xonsh gh-formatting pngcrush pandoc p10k git-standup gvcolor cupsd gh-ssh-key cargo-build git-blame nix-shell docker-run shc git-init eslint rails-generate prettier podman dvc ibmcloud-login zipinfo gv2gml exa go-clean perl mtr exec conda in2csv bq lpr drupal-check git-sed cradle glab-repo git-mailinfo textql mvn pinky brew-bundle sort npm-check man cargo-clippy mr dotnet-ef msfvenom cat git-rename-tag npm-name samtools sha224sum tar pvecm sbcl sphinx-build mytop standard openssl-prime dirname local hsw-cli terraform-fmt printenv mp4box jhipster airpaste gh dhcpwn enca pio-upgrade glib-compile-resources host virsh-pool-undefine stormlock gh-issue-create ansible-doc git-maintenance jarsigner wordgrinder git-config aws-cur sl sudo cmake aria2c sqlmap unzip pm2 pamixer git-help ipsumdump pdfposter edgepaint shuf git-info boot smalltalkci r2e salt-key sed amass-intel mixxx pueue-stash ipaggmanip cargo-test go-install ncdu xmlto unflatten dokku elinks gh-help envsubst csvgrep pio-init texdoc dcg rga openconnect composer gitlab guetzli docker-secret wait phploc deluged mongod truffle detox dvc-commit http-server-upload sha512sum tldrl khal quota pg_dumpall pg_dump transcode docker-rmi readlink pgrep duc gitlab-runner nproc tmux qpdf bash aws-google-auth cake ocamlopt sqsc chown supervisord inkmake nodenv helix git-send-email phpenv nvm psalm docker-volume ln pio-device pio-remote git-annotate renice dcode route hostess htop webpack rbash cut gt gitsome pveperf trash-cli pt llvm-as zlib-flate ansiweather adguardhome mv tput xar git-archive-file transmission-create sshfs texliveonfly sh httpflow htpasswd git-delta who dust batch vi lerna influx cloudflared svn-changelist neofetch f3read hugo vboxmanage csvkit valgrind diff-pdf bzip2 lsof docker-start snyk btm xcv adb-reverse latexmk http-server pip-install pypy cksum git-fsck diskonaut quilt odps-table salt kate convert gv2gxl where git-prune ssh-keygen tlmgr-check pip-uninstall rainbowstream pueue-start crontab clang-tidy gnuplot postcss poetry fswatch subfinder clang++ hangups git-touch flask git-root pdfseparate patchwork slackcat git-local-commits grap sslscan git-bisect theharvester bundletool-dump bcomps fzf f3write cargo head reboot system_profiler bless pmset open airportd stat sntpd spctl universalaccessd defaults textutil secd xattr mdfind machine indent networkquality as chflags xml2man whatis split diskutil dot_clean notifyd usernoted filecoordinationd afplay xcrun securityd uptime automountd wacaw date coreauthd archey ping launchctl sips md5 opensnoop m bnepd systemsetup fsck sysctl carthage launchd scutil nvram dark-mode emond coreautha spotify whence imgcat nettop lldb hdiutil apachectl brightness dd lipo vpnd dmesg qlmanage base64 yabai caffeinate pbcopy fileicon xsltproc shortcuts log xed rename plutil ditto afinfo wifi-password uuidgen softwareupdate mkfile cloudphotod pkgutil bc ocspd csrutil port sw_vers photoanalysisd yaa coreaudiod wc pbpaste avbdeviced tail timed uname xctool w tmutil istats mdls shutdown nfcd mas distnoted arch applecamerad pod sdef xcode-select safeejectgpu screencapture du networksetup top csshx asr mdutil cfprefsd xcodebuild fdesetup photolibraryd airport getfileinfo xip cal icalbuddy shuf appsleepd sed valet readlink look bird drutil codesign route security locate duti osascript say
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ^

^{[TAB] represents pressing the tab key and is not actually visible. $ is the prompt, tldr [TAB] is user input, and the rest is error output.}

Functionality after these changes:

$ tldr [TAB]
2to3                        lerna
7z                          less
7za                         lex
7zr                         license
…and 1080 more rows

^{[TAB] represents pressing the tab key and is not actually visible. $ is the prompt, tldr [TAB] is user input, and the rest is output.}

Escape every tldr-page name to prevent fish syntax errors 45cd3d5

This fixes the problem in which special characters in fish were not
escaped when fish shell completion was added in #17, because at the time
none of the pages in https://github.com/tldr-pages/tldr had names that
were syntactically special in fish. This meant that escaping was
unnecessary.

However, as a result of tldr-pages/tldr#7530*,
which added the files [.md and [[.md, the fish shell autocompletion
will now cause a syntax error in fish whenever autocompletion triggers.

This syntax error fills stderr with long error messages and prevents the
fish autocompletion from running. This problem is fixed by escaping
characters like [, which is done in this commit.

*Update: [.md was actually introduced before [[.md in tldr-pages/tldr#5205 instead of tldr-pages/tldr#7530. This means that fish autocompletion has been broken since Mar 10, 2021.

Prevent filenames from displaying in fish autocomplete c4cfc4d

When using tldr to show a tldr-page, specifying a file path instead of
a name of a page is not allowed and will simply fail with the message
This page doesn't exist yet!.

However, when using fish autocompletion, it will display file and
directory names along with the names of tldr-pages, even though using
those suggestions results in an error.

This commit tells fish that it should not complete filenames.

Require a filepath after -r in fish autocomplete 6cfe15a

tldr accepts a -r/--render argument, which is used like
tldr --render <PATH> or tldr -r <PATH>.

The current behavior for fish autocompletion of the --render option
added PATH as a literal value for completion, meaning that it would
suggest PATH itself as a valid path.

Instead, fish should autocomplete paths for us, and the value PATH
should be removed as a literal autocompletion option.

Documentation for complete (fish builtin)

Make fish-shell autocompletion smarter a839565

tldr fish autocompletion is now functional, but the autocompletion
will sometimes suggest things that are invalid, such as:

• Suggesting more tldr-page names after autocompleting the first, even
  though you can only get one tldr-page at a time.
• Recommending incompatible option combinations, like suggesting
  --update, --help, and --render at the same time.
• Suggesting multiple file paths after specifying --render, even
  though that isn't valid syntax.

This commit resolves these problems by checking to see what values have
already been entered. This makes the suggestions more "intelligent".

Remove redundant options in fish completion 2dc6b41

The documentation for complete lists -x as an alias for -rf.

This allows for some options to be removed because their functionality
is already enabled by other flags.

This change is just refactoring. No functionality is different compared
to the last commit.

Why the change?

The first change is very important because fish autocompletion is broken without it.
The other commits resolve problems where the autocompletion suggests values that are not actually valid.

All of these changes make the fish autocompletion more useful.

How can this be tested?

This modifies the shell autocompletion and not the main source code. I believe this can only be tested manually by installing the shell completion file in fish and verifying that it works.
I can verify that it works on my machine.

Every modification entirely uses functions that are fish builtins, so the completions should work for every instance of fish.

Where to start code review?

All changes to code are in autocomplete/complete.fish. Five separate changes to improve the shell completion have been made.
The CHANGELOG.md was also updated as this PR fixes a fatal bug in fish autocompletion.

Documentation: https://fishshell.com/docs/current/cmds/complete.html,
https://fishshell.com/docs/current/completions.html#completion-own.

Relevant tickets?

tldr-pages/tldr#5205, tldr-pages/tldr#7530, #17, #87

---

These changes are explicitly licensed under the MIT License.

[superatomic]

I've made additional improvements to fish autocompletion in addition to the critical bug fix. Now, it won't repeatedly suggest things over and over (even though its suggestions were invalid) and the code is tidier.

I believe this PR is ready to be merged, especially because it fixes a bug that caused fish-shell completion to be broken since March 10, 2021.

[github-actions]

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

[superatomic]

Does anyone have the ability to review this PR? It's been finished for a while and fish shell completion is broken without it.

[github-actions]

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

[superatomic]

Is tldr-c-client still maintained? I have been unable to use the client alongside fish-shell due to the broken autocompletion, and this fix hasn't gotten any review for months.

[johnflavin-fw]

Hi! Thanks for doing this. I wish I could approve/merge but I am a lowly user just like you.

I was preparing to submit my own PR to fix this issue before I found yours. I've left comments about some of the changes I had made that you didn't. Might be easier to combine our efforts and fix everything at once.

[johnflavin-fw]

Couple more comments.

[johnflavin-fw]

Pinging people who have recently approved / merged PRs: @MasterOdin @owenvoke @CleanMachine1

Any additional changes needed to merge this?

[MasterOdin]

I'm happy to merge this once you (@johnflavin-fw) and @superatomic are aligned with changes (@johnflavin-fw please approve once you're satisfied). I don't use fish or know the syntax for this file, so I cannot give feedback on the suggested changes.

[superatomic]

There's a few more changes that I'd like to make, but after that, let's finally get this merged!

[johnflavin-fw]

Looks great to me! I've tested it locally and haven't seen any issues.

[superatomic]

I want to try to make the command completion be more dynamic in how it suggests certain flags; for example, the --help flag should block any other completions, and typing any flags or tldr-page names should prevent the --help flag from appearing. It's a lot more complex, so if I can't do it in a reasonable way, we can merge this PR without them.

[MasterOdin]

Sounds good @superatomic. Just ping here in the PR again once you'd like me to merge, but if you do end up making larger changes, I'd probably ask @johnflavin-fw to do another re-review.

[superatomic]

Okay, I'm made all of the improvements that I can make. I'm not sure if builtin functions exist for implementing anything more complex.

@johnflavin-fw it would be great if you did another review. I made a lot of changes that restricted where different options could be autocompleted, and it's very possible that I accidentally made a regression somewhere.

Otherwise, if everything's working okay, let's finally get this PR merged! 🎉

[johnflavin-fw]

I've tried it out. Everything seems to work as far as I can tell. LGTM

[superatomic]

I made a small refactoring by renaming __tldr_no_os_choice_opt_and_p to __tldr_no_os_choice_opt_nor_p to be a bit clearer. No functionality was changed in my last commit.

LGTM!

[johnflavin-fw]

@MasterOdin Ready to merge

[superatomic]

@MasterOdin Do we have to do anything else to merge this? We both agree that this PR is ready to be merged.

[MasterOdin]

Apologies, this completely slipped off my radar (again).

Thanks for the efforts @superatomic and @johnflavin-fw on this!