Skip to content

Fix STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE SpotBugs issue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Fix STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE SpotBugs issue #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/de/rub/nds/crawler/data/BulkScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

import de.rub.nds.crawler.constant.JobStatus;
import java.io.Serializable;
import java.text.SimpleDateFormat;
import java.time.Instant;
import java.util.Date;
import java.time.ZoneId;
import java.time.format.DateTimeFormatter;
import java.util.EnumMap;
import java.util.Map;
import javax.persistence.Id;
Expand Down Expand Up @@ -51,7 +51,8 @@ public class BulkScan implements Serializable {

private String crawlerVersion;

private static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd_HH-mm");
private static final DateTimeFormatter DATE_FORMATTER =
DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm").withZone(ZoneId.systemDefault());

@SuppressWarnings("unused")
private BulkScan() {}
Expand All @@ -71,8 +72,7 @@ public BulkScan(
this.finished = false;
this.startTime = startTime;
this.monitored = monitored;
this.collectionName =
name + "_" + dateFormat.format(Date.from(Instant.ofEpochMilli(startTime)));
this.collectionName = name + "_" + DATE_FORMATTER.format(Instant.ofEpochMilli(startTime));
this.notifyUrl = notifyUrl;
}

Expand Down