Skip to content

Conversation

@ic0ns
Copy link
Contributor

@ic0ns ic0ns commented Jun 24, 2025

Summary

  • Removed unnecessary public modifiers from test classes and methods following JUnit 5 best practices
  • Updated 78 test files (4 files already had proper modifiers)
  • No functional changes - only visibility modifiers were updated

Changes

  • Test class declarations now use package-private visibility
  • Test methods (@test annotated) now use package-private visibility
  • Lifecycle methods (@beforeeach, @AfterEach, @BeforeAll, @afterall) now use package-private visibility
  • Inner classes and helper methods now use appropriate visibility
  • Kept public modifiers only where required for overriding public methods from parent classes/interfaces

Test plan

  • Run mvn test to ensure all 782 tests still pass
  • Verify code compiles successfully with mvn test-compile
  • All tests pass without any failures

Following JUnit 5 best practices, removed unnecessary public modifiers from:
- Test class declarations (78 test files)
- Test methods annotated with @test
- Lifecycle methods (@beforeeach, @AfterEach, @BeforeAll, @afterall)
- Helper methods and inner classes where appropriate

Kept public modifiers only where required for overriding public methods.
This improves code clarity by using package-private visibility where appropriate.
@ic0ns ic0ns merged commit f4072ac into main Jun 24, 2025
12 checks passed
@ic0ns ic0ns deleted the friendly_tests branch June 24, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants