Fix OBL_UNSATISFIED_OBLIGATION in Scanner class #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing close() method implementation to Scanner class which implements AutoCloseable. This fixes the static analysis warning about potentially unclosed resources. Also added ScannerTest to verify the close() method works correctly.
# Conflicts: # src/test/java/de/rub/nds/scanner/core/execution/ScannerTest.java
TrueSkrillor
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close()method implementation for AutoCloseable interfaceDetails
The Scanner class implements AutoCloseable but was missing the required
close()method. This caused static analysis tools to report a potential resource leak warning.The fix adds a basic
close()method that can be overridden by subclasses if they have resources to clean up.Test plan