s/ECHO/ECH #236
Merged
s/ECHO/ECH #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfpauly
reviewed
May 21, 2020
| title: Encrypted Server Name Indication for TLS 1.3 | ||
| abbrev: TLS 1.3 SNI Encryption | ||
| title: Encrypted ClientHello for TLS 1.3 | ||
| abbrev: TLS 1.3 Encrypted ClientHello |
There was a problem hiding this comment.
TLS Encrypted ClientHello —> TECH!
(Kidding, kidding)
There was a problem hiding this comment.
Seeing this, I think that you should remove 1.3 from the title. Sure, this is 1.3 only, but I think that this design is fine for 1.4 also. If it isn't, I'm sure we can deal with that eventually. I don't want to find that we ship a 1.4 (or 4) that is compatible with this and have people tell me that it isn't compatible.
There was a problem hiding this comment.
That's a fair point. I'll make that change in a separate PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232.