Added better print methods for distinguishing between info and error …#53
Merged
tmbdev merged 2 commits intoocropus-archive:masterfrom Oct 11, 2015
Merged
Added better print methods for distinguishing between info and error …#53tmbdev merged 2 commits intoocropus-archive:masterfrom
tmbdev merged 2 commits intoocropus-archive:masterfrom
Conversation
added 2 commits
July 27, 2015 16:17
changed common.py to no longer use fromstring() but use frombytes() instead (DeprecationWarning)
tmbdev
added a commit
that referenced
this pull request
Oct 11, 2015
Added better print methods for distinguishing between info and error …
Collaborator
|
Sorry it took so long; I've been focusing on CLSTM. |
Author
|
No worries :) Should I make the same changes in the other python files as well? |
kba
pushed a commit
to kba/ocropy
that referenced
this pull request
Dec 16, 2017
Closes ocropus-archive#53. translate_back_locations would fail when the output had a non-zero output class in the first column of the output lattice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed printing to a new (future proof) method and changed the output a bit.
My reasoning behind this is the following:
I am currently writing a nodejs wrapper to build a RESTful API to use ocropy over the web. To be able to easily distinguish if an operation ran correct or not I need to check if ocropy wrote to stderr or not.
If you can agree with these changes, I could add the same printing to the other ocropy methods as well.