test: maximize coverage by ignoring else path when irrelevant

Author: tmlmt

src/classes/recipe.ts

@@ -144,6 +144,7 @@ export class Recipe {
         if (this.sections.length === 0 && section.isBlank()) {
           section.name = line.substring(1).trim();
         } else {
+          /* v8 ignore else -- @preserve */
           if (!section.isBlank()) {
             this.sections.push(section);
           }
@@ -178,6 +179,7 @@ export class Recipe {
       let cursor = 0;
       for (const match of line.matchAll(tokensRegex)) {
         const idx = match.index;
+        /* v8 ignore else -- @preserve */
         if (idx > cursor) {
           items.push({ type: "text", value: line.slice(cursor, idx) });
         }
@@ -288,8 +290,10 @@ export class Recipe {
             index: idxsInList.cookwareIndex,
             quantityPartIndex: idxsInList.quantityPartIndex,
           } as CookwareItem);
-        } else if (groups.timerQuantity !== undefined) {
-          const durationStr = groups.timerQuantity.trim();
+        }
+        // Then it's necessarily a timer which was matched
+        else {
+          const durationStr = groups.timerQuantity!.trim();
           const unit = (groups.timerUnit || "").trim();
           if (!unit) {
             throw new Error("Timer missing unit");
@@ -396,6 +400,7 @@ export class Recipe {
 
     newRecipe.servings = originalServings * factor;
 
+    /* v8 ignore else -- @preserve */
     if (newRecipe.metadata.servings && this.metadata.servings) {
       if (
         floatRegex.test(String(this.metadata.servings).replace(",", ".").trim())
@@ -407,6 +412,7 @@ export class Recipe {
       }
     }
 
+    /* v8 ignore else -- @preserve */
     if (newRecipe.metadata.yield && this.metadata.yield) {
       if (
         floatRegex.test(String(this.metadata.yield).replace(",", ".").trim())
@@ -418,6 +424,7 @@ export class Recipe {
       }
     }
 
+    /* v8 ignore else -- @preserve */
     if (newRecipe.metadata.serves && this.metadata.serves) {
       if (
         floatRegex.test(String(this.metadata.serves).replace(",", ".").trim())

src/classes/shopping_list.ts

@@ -66,7 +66,9 @@ export class ShoppingList {
     this.ingredients = [];
     for (const { recipe, factor } of this.recipes) {
       const scaledRecipe = factor === 1 ? recipe : recipe.scaleBy(factor);
+
       for (const ingredient of scaledRecipe.ingredients) {
+        // Do not add hidden ingredients to the shopping list
         if (ingredient.flags && ingredient.flags.includes("hidden")) {
           continue;
         }
@@ -77,8 +79,8 @@ export class ShoppingList {
 
         let addSeparate = false;
         try {
-          if (existingIngredient) {
-            if (existingIngredient.quantity && ingredient.quantity) {
+          if (existingIngredient && ingredient.quantity) {
+            if (existingIngredient.quantity) {
               const newQuantity: Quantity = addQuantities(
                 {
                   value: existingIngredient.quantity,
@@ -93,8 +95,10 @@ export class ShoppingList {
               if (newQuantity.unit) {
                 existingIngredient.unit = newQuantity.unit;
               }
-            } else if (ingredient.quantity) {
+            } else {
               existingIngredient.quantity = ingredient.quantity;
+
+              /* v8 ignore else -- only set unit if it is given -- @preserve */
               if (ingredient.unit) {
                 existingIngredient.unit = ingredient.unit;
               }

src/parser_helpers.ts

@@ -96,6 +96,7 @@ export function findAndUpsertIngredient(
 
     // Checking whether any provided flags are the same as the original ingredient
     for (const flag of newIngredient.flags!) {
+      /* v8 ignore else -- @preserve */
       if (!existingIngredient.flags!.includes(flag)) {
         throw new ReferencedItemCannotBeRedefinedError(
           "ingredient",
@@ -125,6 +126,7 @@ export function findAndUpsertIngredient(
         }
         quantityPartIndex = existingIngredient.quantityParts!.length - 1;
       } catch (e) {
+        /* v8 ignore else -- expliciting error types -- @preserve */
         if (
           e instanceof IncompatibleUnitsError ||
           e instanceof CannotAddTextValueError
@@ -175,6 +177,7 @@ export function findAndUpsertCookware(
 
     // Checking whether any provided flags are the same as the original cookware
     for (const flag of newCookware.flags) {
+      /* v8 ignore else -- @preserve */
       if (!existingCookware.flags.includes(flag)) {
         throw new ReferencedItemCannotBeRedefinedError(
           "cookware",
@@ -206,6 +209,7 @@ export function findAndUpsertCookware(
               ) - 1;
           }
         } catch (e) {
+          /* v8 ignore else -- expliciting error type -- @preserve */
           if (e instanceof CannotAddTextValueError) {
             return {
               cookwareIndex: cookware.push(newCookware) - 1,
@@ -301,6 +305,7 @@ export function parseListMetaVar(content: string, varName: string) {
   );
   if (!listMatch) return undefined;
 
+  /* v8 ignore else -- @preserve */
   if (listMatch[1] !== undefined) {
     // Inline list: tags: [one, two, three]
     return listMatch[1].split(",").map((tag) => tag.trim());