Correct socket num description in error string #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlange2
approved these changes
May 1, 2023
YHusain1
force-pushed
the
cfspdk-951-socket-num-exceed-size
branch
from
4dd9282 to
1f18860
Compare
with an approproate errno return value.
YHusain1
force-pushed
the
cfspdk-951-socket-num-exceed-size
branch
from
1f18860 to
c194377
Compare
johnlange2
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit,
If the user performs an action on a non-existent socket in excess of max unsigned integer size it will return the value of 2147483647 incorrectly.
After this commit, the passed in socket num will be correctly displayed in the error message.
As well as, added a check to determine if passed socket num is not an integer and returns the set errno appropriately.