Secrets Management using T-Vault as Feature Extension for Jazz #1255

raghits · 2019-12-31T20:42:51Z

Requirements

Add Support for Secrets Management in Jazz using T-Vault as a Feature Extension

Description of the Change

Users can use T-Vault to store and manage their secrets
Users can pull the secrets from T-Vault in their Code

Benefits

Securely managed and use secrets

Possible Drawbacks

None.

Applicable Issues

None.

* Secret management UI changes

…into secret-mgmt-api

API for managing CRUD of users/safes/role with t-vault

Secret management API- followup

* Node10 support (#1204) * nodejs10 support * removing duplicate files * removing python2 traces * fixed spell err * c# support for azure functions * consistent use of servicePlatform and domain * More restrictions on service/domain length More restrictions on service/domain length to cater to IAM role naming style with serverless framework * Swap Python for Node.js icon in create service Signed-off-by: PGobz <p.gobin@gmail.com> * Ordering of supported Nodejs runtimes * Fix for GET /services & added new API path - /services/search (#1214) * created new endpoint for search and exact match provided for services list. * test updated. * POST method for /search is removed. * optimized code with conditions * syntax error fixed * Fix Error with Search Filter (#1219) * syntax error fix * test case update * test case update * reverted change * Added search endpoint check, to provide query result by 'search contains' scenario. * JS error fix * remove updatePolicy which needs to be as part of install/adding account to the stack. (#1226) * make sure providerTimeout has defaults for api and lambda. * reading defaults from config. always setting it. * Hotfix: Setting Default ProviderTimeout for api and function (#1228) * make sure providerTimeout has defaults for api and lambda. * reading defaults from config, always setting it. * Leverage CloudWatch log group tags instead of parsing log group naming convention (#1217) * removed createSubscriptionFilters * changes for retrieving tags from logGroup * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * using {functionName} tag in the config packs. * update signature of functionName. * update function signature. * set the providerTimeout. * Update Authorizers Lambda Function Name (#1232) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * fixes to kinesis streamers (#1233) * changes for replacing variables with actual values in log streamer function. * sls-app providerTimeout and update function signature (#1235) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * Region Update for prod, dev and stg endpoints (#1236) * rebased with node10 and including changes * removed createSubscriptionFilters * changes for retrieving tags from * changes as per review comments * changes as per review comments * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * changes as per review comments * changes as per review comments * update to log-streamer files as per review comments * changes as per review comments * changes as per review comments * changes as per review comments * changes * using {functionName} tag in the config packs. * make sure function name is consistent and attached to API gateway. also set the providerTimeout. * only set providerTimeout for api and function. * changes for build pack function and api * update signature of functionName. * update function signature. * set the providerTimeout. * changes as per review comments and validated in stack * changes for replacing variables with actual values in log streamer function. * changes * Update Log API (#1237) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * servicename and domain as separate fields. * Fix typo Co-authored-by: Satish Malireddi <dev.satishm@gmail.com> Co-authored-by: dimple patel <dimplejpatel93@gmail.com> Co-authored-by: SauravD <43289511+SauarvD@users.noreply.github.com>

develop sync with secret-mgmt

* Bug Fixes * assets sorting changes * spacing fixes * no message * no message * no message * no message * no message * no message * no message * Sort changes * metrics ,assets and space fixes * end time changes * Changes Co-authored-by: Satish Malireddi <dev.satishm@gmail.com> Co-authored-by: Prakash Raghothamachar <raghits@users.noreply.github.com>

claassistantio · 2019-12-31T20:43:54Z

All committers have signed the CLA.

pgobin-zz · 2020-01-03T01:04:04Z

LGTM. Will wait for another review before approval due to lack of context.

builds/serverless-config-pack/aws-events-policies/custom-policy.yml

core/jazz_deployments/package.json

builds/jazz-build-module/service-configuration-data-loader.groovy

devsatishm

Few minor comments.

… not (#1257) * Adding custom role for tvault * Removing unused code * Checking for internal access * Changes in build pack api * fixing syntax err * Fixes during validation * fixes * fixes * fixes * Fix typo * fixes for jazz core functions * fixes for jazz core functions * fixes for create asset role * fixes for create asset role * Making changes in build -apck api * Making changes in build -apck api * Making changes in build -apck api * Making changes in build -apck api * Changes in sls-app build pack * Changes in sls-app build pack * Changes in sls-app build pack * Changes in sls-app build pack * fixing issues * Changes in sls-app build pack * Renaming safe_details to safe * Renaming safe_details to safe * renaming customEventRole to customRole * fixes for cmnts * fixes for cmnts * fixes for cmnts * fixes for cmnts * fixes for cmnts * fixes for cmnts * Fix after validations * Fixing cognito * Fixing cognito * Fix after validations * Removing safe while deleting a service * handling deletion of safe * handling deletion of safe * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixinng safe creation for website issue * fixinng safe creation for website issue * Removed unwanted vars * authorizer change in t-vault api * removing unwanted code * Adding roles per environment * implementing roles per env * modifying build pack api * fix issue * making getting role method common * creating asset * creating asset * fixing issues * syntax issue * fixing issues * Fixing resource removal * adding user specified role * fix for event enabled * fix * fix * fix * fix * fixing account id issue * firx for slsapp * formatting fix * taking accountid from config * in cooperating review comment * in cooperating review comments * updating role policy * changing name * renaming * getting resources from describe stack resources * getting resources from describe stack resources * fix issue * fix issues in slsapp * Fixex in sls-app * creating assets for stack resources in api * fix issues in function * fixing issues in function * fix issues * removing unwanted code * bugfix * Bugfix * alignment issue * REmoving unwanted code Co-authored-by: Satish Malireddi <dev.satishm@gmail.com>

devsatishm

LGTM

swati-sh and others added 30 commits August 12, 2019 13:30

Secret management UI changes (#1129)

c3d5f9b

* Secret management UI changes

Initial draft for tvault API:

4b18c7e

Adding title

f5239af

Adding authentication

b75ef72

updating swagger

ed74028

Fixing minor issues

dc68cb7

Updating tvault url

102e7b4

Bug fixes after validation

7b0a60c

Minor bugfixes

410b9c8

changing logger

dc95718

Updating and revisiting code

580696e

updating swagger

f5ad358

minor bug fixes due to the refactor

8db3ded

minor bug fixes due to the refactor

c7ddf64

removing special charecters from email as it is not supporting in vault

0dcc4b6

fixed spell err

24ee9d1

Fixed log msgs

e3e906c

Updating swagger

3639818

Merge branch 'secret-mgmt-api' of https://github.com/SiniWilson/jazz …

e0c764b

…into secret-mgmt-api

error_type => errorType

1a12900

Addressing review comment

668a7ae

Merge branch 'secret-mgmt-api' of https://github.com/SiniWilson/jazz …

8da49f2

…into secret-mgmt-api

Merge pull request #1157 from SiniWilson/secret-mgmt-api

4bac0eb

API for managing CRUD of users/safes/role with t-vault

Massaging role details

ccad39a

Merge remote-tracking branch 'upstream/secret-mgmt' into secret-mgmt-api

9d1147c

Adding configuration

abc4adc

Adding configuration

4d660b3

Renaming variable

8666075

Renaming variable

0f5f534

Merge pull request #1167 from SiniWilson/secret-mgmt-api

d76d192

Secret management API- followup

Prakash Raghothamachar and others added 6 commits December 26, 2019 14:03

Merge branch 'develop' into secret-mgmt

4591efe

Merge remote-tracking branch 'upstream/secret-mgmt' into secret-mgmt

8a6b12b

Merge pull request #1253 from raghits/secret-mgmt

77144ce

develop sync with secret-mgmt

Alignment fixes (#1254)

b709a83

raghits added the release label Dec 31, 2019

raghits requested review from pgobin-zz, devsatishm and chimpuz December 31, 2019 20:43

raghits requested a review from SiniWilson January 3, 2020 00:56

Merge branch 'develop' into secret-mgmt

9267bc0

devsatishm reviewed Jan 11, 2020

View reviewed changes

builds/serverless-config-pack/aws-events-policies/custom-policy.yml Outdated Show resolved Hide resolved

devsatishm reviewed Jan 11, 2020

View reviewed changes

builds/serverless-config-pack/aws-events-policies/custom-policy.yml Outdated Show resolved Hide resolved

devsatishm reviewed Jan 11, 2020

View reviewed changes

core/jazz_deployments/package.json Show resolved Hide resolved

devsatishm reviewed Jan 11, 2020

View reviewed changes

builds/jazz-build-module/service-configuration-data-loader.groovy Outdated Show resolved Hide resolved

devsatishm suggested changes Jan 11, 2020

View reviewed changes

raghits and others added 2 commits January 16, 2020 13:55

Merge branch 'develop' into secret-mgmt

940772e

raghits and others added 2 commits January 16, 2020 16:30

add check for TVAULT.IS_ENABLED field type boolean. (#1261)

0b05e77

Merge branch 'develop' into secret-mgmt

7d20088

devsatishm self-requested a review January 17, 2020 01:05

devsatishm approved these changes Jan 17, 2020

View reviewed changes

pgobin-zz approved these changes Jan 17, 2020

View reviewed changes

devsatishm merged commit 1b9afb3 into develop Jan 17, 2020

devsatishm deleted the secret-mgmt branch February 7, 2020 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Secrets Management using T-Vault as Feature Extension for Jazz #1255

Secrets Management using T-Vault as Feature Extension for Jazz #1255

raghits commented Dec 31, 2019

claassistantio commented Dec 31, 2019 •

edited

Loading

pgobin-zz commented Jan 3, 2020

devsatishm left a comment

devsatishm left a comment

Secrets Management using T-Vault as Feature Extension for Jazz #1255

Secrets Management using T-Vault as Feature Extension for Jazz #1255

Conversation

raghits commented Dec 31, 2019

Requirements

Description of the Change

Benefits

Possible Drawbacks

Applicable Issues

claassistantio commented Dec 31, 2019 • edited Loading

pgobin-zz commented Jan 3, 2020

devsatishm left a comment

Choose a reason for hiding this comment

devsatishm left a comment

Choose a reason for hiding this comment

claassistantio commented Dec 31, 2019 •

edited

Loading