fix(signature_mngr): hack to fix initialization cycle in sig mngr #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon startup the signature manager needs to fetch/generate a signing key and use it, then, when it comes to the step of using it, it does so by sending a message to itself (via public set_key function), problem is that this future is blocked with `.wait` meaning the actor is not able to process any incoming message until the future resolves, but it can't resolve because it waiting for the actor to accept the SetKey message.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon startup the signature manager needs to fetch/generate a signing key and use it, then, when it comes to the step of using it, it does so by sending a message to itself (via public set_key function), problem is that this future is blocked with
.waitmeaning the actor is not able to process any incoming message until the future resolves, but it can't resolve because it waiting for the actor to accept the SetKey message.Logs
Now we can see that the signature manager indeed receives the key and it is ready to sign.