Enable support for canvas-prebuilt package#1754
Merged
domenic merged 6 commits intojsdom:masterfrom Mar 12, 2017
asturur:master
Merged
Enable support for canvas-prebuilt package#1754domenic merged 6 commits intojsdom:masterfrom asturur:master
domenic merged 6 commits intojsdom:masterfrom
asturur:master
Conversation
Contributor
Author
|
@domenic any thought about this? |
Contributor
Author
|
@tmpvar, @Sebmaster anyone? |
Member
|
Sorry, we're all busy and mostly work on jsdom on weekends. I wasn't able to do so last weekend. |
Contributor
Author
|
no worries! I ll wait the weekend. |
Member
|
This is really great stuff! Thanks especially for adding a CI test configuration for it. I was wondering if we should just always include canvas-prebuilt, but it looks like according to https://www.npmjs.com/package/canvas-prebuilt that would not be great for every platform, so the approach you went with here makes sense to me. |
Contributor
Author
|
Super! this will ease also fabricjs installations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canvas-prebuilt is a package from @chearon https://github.com/chearon/node-canvas-prebuilt, contributor of node-canvas.
Is easier to install for most of the situation and is same as canvas, but prebuilt.
Is a drop in replacement with a different name, i made this PR to enable the us of this package in jsdom.