Highlight Current Node #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Need to connect the click to the goto - Need to get index instead of line-number. Alternatively, we can convert in the graph itself.
We should probably get more data out of the graph, and play with what makes sense for people. Also, we should add handling for clusters, probably with selection in this case. This is related to #2.
We map the code positions to nodes, and can later find the right node. Sadly, I can't wrap my head around the codemirror docs yet to make it interactive, so it is only via the browser console.
But there are some significant issues. - Only implemented for Python - code->graph requires that every line of code is mapped to the nodes - nodes only map to line number, they should map to the actual text if possible.
# Conflicts: # src/control-flow/cfg-python.ts # src/test/__snapshots__/commentTest.test.ts.snap
…r planning for this.
This is important for debugging! To enable it, set the `segmentation` URL param in the demo
Editing the code now updates the graph highlighting as expected
…statement, for purposes of CFG node mapping
While CSS is the way to go in the future, this is a simpler solution for now. It also makes it easier to maintain alongside the extension itself.
This was not ready, so it's removed from this PR.
They very well belong there, and it makes reading the code easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight the CFG node matching the current cursor position in the code.
Closes #3