Highlight prefix not boldable

[laur89]

How can we set the prefix highlight bold?
It used to work as

set -g @prefix_highlight_fg "colour239,bold"

but now it simply prints 'bold' out.
Looks like highlight doesn't have an attr setting as copy & sync have so how to make highlight prefix bold?

Using ver 41d4ef4
Potentially related to #26?

[vdumitraskovic]

It seems broken for me, as well :(

[dsedivec]

How can we set the prefix highlight bold?
It used to work as

set -g @prefix_highlight_fg "colour239,bold"

but now it simply prints 'bold' out.

@laur89, try this instead in your tmux.conf and let us know if it works for you, please?

set -g @prefix_highlight_fg "colour239#,bold"

I'd call that a temporary fix. To the maintainers, I think @smesko85 might be on the right track: Does format_style need to be called on the prefix_highlight_fg and ..._bg values? Looks like it's being called on the other settings but not those two.

[vdumitraskovic]

@dsedivec Thank you!
I am using hex colors and I can finally set 'bold', again :)

set -g @prefix_highlight_fg "#d9d9d9#,bold"

[laur89]

Same here, @dsedivec recommendation works. Could you please explain why is it so?

[dsedivec]

Same here, @dsedivec recommendation works. Could you please explain why is it so?

I believe you see "bold" in the status bar because prefix_highlight_fg is being interpolated into a tmux format string like #{?cond,true,false} and the comma before "bold" is not escaped. Inside conditionals, if you want to include a comma in the true or false parts, that comma needs to be escaped as #,, per the docs.

I think tmux-prefix-highlight actually takes a different route to avoid commas inside conditionals: it tries to turn, for example, #[fg=#d9d9d9,bold] into (I think) #[fg=#d9d9d9]#[bold], which is also valid and avoids the comma. That transformation is being applied to other tmux-prefix-highlight settings, but just not to prefix_highlight_fg and prefix_highlight_bg anymore, and I suspect that's an oversight.

[MunifTanjim]

That transformation is being applied to other tmux-prefix-highlight settings, but just not to prefix_highlight_fg and prefix_highlight_bg anymore, and I suspect that's an oversight.

Hmm 🤔 I introduced that transformation. I thought those two options are for only setting color (as mentioned in the README.md)

The colors used for the prefix highlight can be configured:

set -g @prefix_highlight_fg 'white' # default is 'colour231'
set -g @prefix_highlight_bg 'blue'  # default is 'colour04'

That's why I didn't applied the transformation on those two options.

[laur89]

That's why I didn't applied the transformation on those two options.

Not following here - what was the reason?

[MunifTanjim]

what was the reason?

I thought those two options are for setting only color (not other attributes). Clearly, I was wrong because those are being used to apply other attributes too.

The fix would be to change this line:

tmux-prefix-highlight/prefix_highlight.tmux

Line 67 in 41d4ef4

local -r prefix_highlight="#[fg=$fg_color]#[bg=$bg_color]"

to this:

    local -r prefix_highlight="$(format_style "fg=$fg_color,bg=$bg_color")"

That should work (not tested).

As I don't use this plugin anymore (I made my trimmed down version of this: tmux-mode-indicator), if somebody wants to make a PR with this change, they're welcome.

[dsedivec]

As I don't use this plugin anymore (I made my trimmed down version of this: tmux-mode-indicator), if somebody wants to make a PR with this change, they're welcome.

Done in #29. Thanks!