Skip to content

Commit f66d652

Browse files
committed
chore(ruff): Manual fixes for workspace/builder.py
src/tmuxp/workspace/builder.py:258:9: B018 Found useless expression. Either assign it to a variable or remove it. src/tmuxp/workspace/builder.py:456:45: B023 Function definition does not bind loop variable `pane_config` src/tmuxp/workspace/builder.py:457:32: B023 Function definition does not bind loop variable `pane_config` src/tmuxp/workspace/builder.py:464:35: B023 Function definition does not bind loop variable `pane_config` src/tmuxp/workspace/builder.py:465:32: B023 Function definition does not bind loop variable `pane_config`
1 parent 5f23e3b commit f66d652

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

src/tmuxp/workspace/builder.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ def build(self, session: t.Optional[Session] = None, append: bool = False) -> No
255255
assert session.server is not None
256256

257257
self.server: "Server" = session.server
258-
self.server.sessions
258+
assert self.server.sessions is not None
259259
assert self.server.has_session(session.name)
260260
assert session.id
261261

@@ -452,15 +452,19 @@ def iter_create_panes(
452452
pane = window.attached_pane
453453
else:
454454

455-
def get_pane_start_directory():
455+
def get_pane_start_directory(
456+
pane_config: t.Dict[str, str], window_config: t.Dict[str, str]
457+
) -> t.Optional[str]:
456458
if "start_directory" in pane_config:
457459
return pane_config["start_directory"]
458460
elif "start_directory" in window_config:
459461
return window_config["start_directory"]
460462
else:
461463
return None
462464

463-
def get_pane_shell():
465+
def get_pane_shell(
466+
pane_config: t.Dict[str, str], window_config: t.Dict[str, str]
467+
) -> t.Optional[str]:
464468
if "shell" in pane_config:
465469
return pane_config["shell"]
466470
elif "window_shell" in window_config:
@@ -486,8 +490,14 @@ def get_pane_shell():
486490

487491
pane = window.split_window(
488492
attach=True,
489-
start_directory=get_pane_start_directory(),
490-
shell=get_pane_shell(),
493+
start_directory=get_pane_start_directory(
494+
pane_config=pane_config,
495+
window_config=window_config,
496+
),
497+
shell=get_pane_shell(
498+
pane_config=pane_config,
499+
window_config=window_config,
500+
),
491501
target=pane.id,
492502
environment=environment,
493503
)

0 commit comments

Comments
 (0)