support passphase protected private key load#35
Merged
toddr merged 2 commits intocpan-authors:masterfrom Mar 10, 2022
Merged
Conversation
atoomic
approved these changes
Mar 10, 2022
Collaborator
atoomic
left a comment
atoomic
left a comment
There was a problem hiding this comment.
LGTM some minor comments
| BIO* stringBIO; | ||
| char* passphase = NULL; | ||
| STRLEN passphaseLength = 0; | ||
| char* cipher_name; |
| const EVP_CIPHER* enc = NULL; | ||
| CODE: | ||
| if (SvPOK(cipher_name_SV) && !SvPOK(passphase_SV)) { | ||
| croak("Both passphase and cipher name are required"); |
Collaborator
There was a problem hiding this comment.
it s more: passphrase is missing consider adding a hint to your error message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I applied the patch in issue #16 to latest code accordingly, which supports:
Test case updated.
Please review, I need this feature to replace some code working with Crypt::RSA.
Looking forward to merge and a new release on CPAN.
Cheers, Dongxu
Closes #16
Closes #19