fix: jumping to edgeless-editor by "View in Edgeless" in the default demo #6486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
congzhou09
changed the title
Saul-Mirone
approved these changes
Mar 19, 2024
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Mar 25, 2024
## Features - toeverything/blocksuite#6544 @golok727 - toeverything/blocksuite#6543 @golok727 - toeverything/blocksuite#6536 @donteatfriedrice - toeverything/blocksuite#6497 @doouding - toeverything/blocksuite#6514 @regischen - toeverything/blocksuite#6523 @donteatfriedrice - toeverything/blocksuite#6530 @zzj3720 - toeverything/blocksuite#6526 @fourdim - toeverything/blocksuite#6532 @donteatfriedrice - toeverything/blocksuite#6493 @golok727 - toeverything/blocksuite#6529 @zzj3720 - toeverything/blocksuite#6528 @zzj3720 - toeverything/blocksuite#6509 @zzj3720 - toeverything/blocksuite#6525 @doodlewind - toeverything/blocksuite#6502 @donteatfriedrice - toeverything/blocksuite#6489 @Flrande ## Bugfix - toeverything/blocksuite#6558 @fourdim - toeverything/blocksuite#6556 @fourdim - toeverything/blocksuite#6547 @fundon - toeverything/blocksuite#6537 @golok727 - toeverything/blocksuite#6531 @donteatfriedrice - toeverything/blocksuite#6524 @doodlewind - toeverything/blocksuite#6519 @regischen - toeverything/blocksuite#6517 @doodlewind - toeverything/blocksuite#6516 @doodlewind - toeverything/blocksuite#6510 @donteatfriedrice - toeverything/blocksuite#6511 @congzhou09 - toeverything/blocksuite#6507 @doouding - toeverything/blocksuite#6500 @fourdim - toeverything/blocksuite#6486 @congzhou09 - toeverything/blocksuite#6495 @donteatfriedrice - toeverything/blocksuite#6488 @Saul-Mirone - toeverything/blocksuite#6482 @Flrande - toeverything/blocksuite#6558 @fourdim ## Refactor - toeverything/blocksuite#6548 @doodlewind - toeverything/blocksuite#6522 @doodlewind - toeverything/blocksuite#6518 @regischen - toeverything/blocksuite#6521 @Saul-Mirone ## Misc - toeverything/blocksuite#6557 @fourdim - toeverything/blocksuite#6546 @Flrande - docs: update package desc - toeverything/blocksuite#6527 @fourdim - toeverything/blocksuite#6505 @Brooooooklyn - toeverything/blocksuite#6503 @fourdim - v0.13.0 - toeverything/blocksuite#6496 @doodlewind - toeverything/blocksuite#6562 @donteatfriedrice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default demo's 'View in Edgeless' did not work because of two reasons:
So I fill in these two lacks.
Besides, "editorContainer's mode property's reactivity to mode change in PageRootService" is an inherent behavoir with regard to the stable PageRootService, so I move this realization into the EditorContainer class to avoid redundant outer configs.
before(default demo):
before.mp4
after(default demo):
after.mp4
after(starter demo):
after-starter.mp4