Skip to content

fix(edgeless): paste as note block if all other cases fails #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fourdim merged 10 commits into from
Apr 19, 2024
Merged

fix(edgeless): paste as note block if all other cases fails #6827

fourdim merged 10 commits into from
Apr 19, 2024

Conversation

@golok727
Copy link
Contributor

@golok727 golok727 commented Apr 19, 2024 •
edited by fourdim
Loading

Close #6788, close #6609.

fix.mp4

@vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) Apr 19, 2024 11:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:05am

@golok727 golok727 marked this pull request as draft April 19, 2024 08:31
@golok727 golok727 marked this pull request as ready for review April 19, 2024 09:23
@graydawnc
Copy link
Collaborator

graydawnc commented Apr 19, 2024

Thank you for your work. We plan to gradually reduce the use of canvas text in the future. Instead of pasting the content into canvas text, it may be a better way to add a note block at the paste position and paste the content into the newly added note block. Are you willing to do this? Thanks again!

@golok727 golok727 marked this pull request as draft April 19, 2024 09:25
@golok727
Copy link
Contributor Author

golok727 commented Apr 19, 2024

Thank you for your work. We plan to gradually reduce the use of canvas text in the future. Instead of pasting the content into canvas text, it may be a better way to add a note block at the paste position and paste the content into the newly added note block. Are you willing to do this? Thanks again!

Of course, I will do it :)

@golok727
Copy link
Contributor Author

golok727 commented Apr 19, 2024

@donteatfriedrice PTAL.

fix.mp4

@golok727 golok727 changed the title feat(edgeless): paste as text if all other cases fails feat(edgeless): paste note block if all other cases fails Apr 19, 2024
@golok727 golok727 changed the title feat(edgeless): paste note block if all other cases fails fix(edgeless): paste note block if all other cases fails Apr 19, 2024
@golok727 golok727 changed the title fix(edgeless): paste note block if all other cases fails fix(edgeless): paste as note block if all other cases fails Apr 19, 2024
@graydawnc
Copy link
Collaborator

graydawnc commented Apr 19, 2024

@donteatfriedrice PTAL.

fix.mp4

Looks great! Thanks for the feat!

@graydawnc graydawnc requested a review from fourdim April 19, 2024 11:09
@golok727 golok727 marked this pull request as ready for review April 19, 2024 11:24
@golok727 golok727 requested a review from fourdim April 19, 2024 18:33
fourdim
fourdim approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@fourdim fourdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fourdim fourdim merged commit 0a00322 into toeverything:master Apr 19, 2024
@golok727 golok727 deleted the radhu/paste-text branch April 19, 2024 18:55
@EYHN EYHN mentioned this pull request Apr 22, 2024
Merged
EYHN added a commit to toeverything/AFFiNE that referenced this pull request Apr 23, 2024
@EYHN
chore: bump blocksuite (#6666)
c425cfa 
## Features
- toeverything/blocksuite#6842 @donteatfriedrice
- toeverything/blocksuite#6836 @regischen

## Bugfix
- toeverything/blocksuite#6837 @pengx17
- toeverything/blocksuite#6803 @lawvs
- toeverything/blocksuite#6843 @donteatfriedrice
- toeverything/blocksuite#6838 @donteatfriedrice
- toeverything/blocksuite#6834 @regischen
- toeverything/blocksuite#6835 @donteatfriedrice
- toeverything/blocksuite#6831 @pengx17
- toeverything/blocksuite#6827 @golok727
- toeverything/blocksuite#6828 @regischen

## Refactor

## Misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fourdim fourdim fourdim approved these changes

@doodlewind doodlewind Awaiting requested review from doodlewind

@Saul-Mirone Saul-Mirone Awaiting requested review from Saul-Mirone

Assignees

No one assigned

Labels

None yet

Projects

BlockSuite Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copy content and paste in edgeless throw error SyntaxError: "undefined" is not valid JSON

3 participants

@golok727 @graydawnc @fourdim