fix: edgeless selection may disappear when typing on edgeless text #7443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Saul-Mirone
reviewed
Jun 27, 2024
| to: null, | ||
| }); | ||
| this.host.selection.set([selection]); | ||
| this.host.selection.setGroup('note', [selection]); |
Collaborator
There was a problem hiding this comment.
Do we have better solution? I want to move the note group from std to blocks. Not sure if it's possible.
Collaborator
Author
There was a problem hiding this comment.
I think it's fine, but before that, we need to improve the type of the group first, now it's all hard-coded.
Saul-Mirone
approved these changes
Jun 27, 2024
Merge activity
|
Flrande
force-pushed
the
flrande/fix/et-select-0627
branch
from
f949776 to
5ac1586
Compare
Saul-Mirone
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 28, 2024
## Features ## Bugfix - toeverything/blocksuite#7444 @Saul-Mirone - toeverything/blocksuite#7445 @doouding - toeverything/blocksuite#7443 @Flrande - toeverything/blocksuite#7440 @doouding ## Refactor - toeverything/blocksuite#7442 @Flrande ## Misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close BS-652
CleanShot.2024-06-27.at.17.20.59.mp4