This repository was archived by the owner on Oct 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Controller Gas Proxy and CHI token integration #605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssociated mock contracts
872f810 to
1ef8a58
Compare
mischat
suggested changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some changes in there, with my comments, that we should discuss or change accordingly.
i-stam
reviewed
Jul 28, 2020
i-stam
reviewed
Jul 28, 2020
5a8314c to
068d372
Compare
9295eba to
a78ab8a
Compare
a78ab8a to
c3a1261
Compare
i-stam
approved these changes
Jul 31, 2020
mischat
reviewed
Jul 31, 2020
f48f339 to
f6a3e6f
Compare
mischat
approved these changes
Jul 31, 2020
name from returndata to returnData
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Update
Note that this requires the use of
pragma experimental ABIEncoderV2;even though since 0.6.0 it's no longer experimental: