Only call reuse_address on Unix#432
Closed
alexcrichton wants to merge 1 commit intotokio-rs:masterfrom
Closed
Conversation
The standard library only Does this on Unix, and otherwise it's a source of divergent behavior on Windows. Closes tokio-rs#400
alexcrichton
force-pushed
the
only-reuse-address-on-unix
branch
from
23ae8ea to
0c2a63e
Compare
|
Just my optinion: But shouldn't mio behave the same on all oses, at least as much as possible? I think mio shouldn't set reuse_address at all, but let the user set this, if he needs it. This way the behaviour on all platforms would be the same. Or is the resuse_address a default thing on unix systems? |
Member
|
Mio's defaults should result in portable code as much as possible. Aka, behavior that is as close as possible on all supported platforms. OS defaults diverge, so some different options will be required as defaults. If this is not the desired behavior, Mio allows the developer to configure the options as desired. |
Member
|
Thanks. Merged here 5d07d0b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard library only Does this on Unix, and otherwise it's a source of
divergent behavior on Windows.
Closes #400