Ensure errors on TCP writes happen on Windows #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
windows-write-error
branch
2 times, most recently
from
e9c0bb3 to
d196831
Compare
Previously an error in a TCP write might accidentally get covered up as the `write` function didn't check for `State::Error`. This updates that logic to propagate the error out to ensure if we see an error it goes upwards.
alexcrichton
force-pushed
the
windows-write-error
branch
from
d196831 to
14ed3b5
Compare
carllerche
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an error in a TCP write might accidentally get covered up as the
writefunction didn't check forState::Error. This updates that logic topropagate the error out to ensure if we see an error it goes upwards.
Closes tokio-rs/tokio-core#243