Skip to content

Comments

Apply a lowercase to all the mio names.#752

Closed
fa7ca7 wants to merge 1 commit intotokio-rs:masterfrom
fa7ca7:unify-mio-case
Closed

Apply a lowercase to all the mio names.#752
fa7ca7 wants to merge 1 commit intotokio-rs:masterfrom
fa7ca7:unify-mio-case

Conversation

@fa7ca7
Copy link
Contributor

@fa7ca7 fa7ca7 commented Oct 27, 2017

Fix for #679.

@carllerche
Copy link
Member

Thanks for contrib 👍

I think that "Mio" should be treated as a proper noun at this point (capitalizing the first letter).

Capitalization has changed over time due to what the "Mio" name meant. It has converged to being a proper noun.

@KodrAus
Copy link

KodrAus commented Nov 7, 2017

Maybe we should update the references in the README too. There are a few different ways the lib is referred to in there:

  • mio
  • mio
  • MIO

@carllerche
Copy link
Member

Updating the README would be good too, however, mio refers to the crate literal (what is imported).

@fa7ca7
Copy link
Contributor Author

fa7ca7 commented Dec 1, 2017

Closing this PR since changes are senseless.

@fa7ca7 fa7ca7 closed this Dec 1, 2017
@KodrAus
Copy link

KodrAus commented Dec 1, 2017

@dethoter I don't think these changes are senseless, and am glad you got stuck in and made them! It's subtle but significant to have consistent naming.

@carllerche
Copy link
Member

Yeah, I don't think it is senseless either, it is pretty subtle :)

@fa7ca7
Copy link
Contributor Author

fa7ca7 commented Dec 2, 2017

Apologize, I haven't been clear enough. @carllerche decided that

"Mio" should be treated as a proper noun

Here I changed Mio to mio that's incorrect according to accepted decision. So exactly this PR is senseless. I'll open a new one to update README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants