UnixReady::priority conflicts with Ready::writable (on Linux at least)#897
Merged
Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom Mar 7, 2019
Merged
UnixReady::priority conflicts with Ready::writable (on Linux at least)#897Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom
Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom
Conversation
Thomasdezeeuw
approved these changes
Jan 20, 2019
Collaborator
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
If you add the regression test I think this is good to merge.
On Linux, Ready::from(UnixReady::priority()).is_writable() = true Use a separate bit instead. Fixes: tokio-rs#896 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Check basic bit conflicts by comparing the sum and the or of all known flags. Add a regression test for tokio-rs#896. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
carllerche
approved these changes
Mar 7, 2019
Member
|
@Thomasdezeeuw feel free to merge whenever. |
Collaborator
|
Will merge once CI is ready. |
Collaborator
|
Thanks @elmarco. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #896