Skip to content

syscall! macros hide unsafe code #1753

@djkoloski

Description

@djkoloski

While auditing mio for Fuchsia, I usually grep for unsafe and audit the unsafe blocks. However, the syscall! macros for unix and windows include their own unsafe { .. } blocks wrapping the underlying unsafe functions. This makes it harder to ensure that every syscall is properly justified. Removing the unsafe blocks from the macro would help solve this problem; whoever uses the macro would need to wrap it in unsafe { .. } and provide a safety comment at the usage site.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions