`poll.poll()` and `EINTR`

[jedisct1]

poll.poll() can currently return io::ErrorKind::Interrupted when an inner system call is being interrupted.

As all examples tend to ignore this, I was wondering whether this behavior was intentional, or if the function should silently retry when it happens. I'd be glad to submit a pull request for the later.

[carllerche]

It was intentional to not catch it.

There should definitely be a way to call poll that doesn't catch EINTR, however if that should be the default, I don't know... Also, handling EINTR in the examples would add a bunch of noise :P.

Maybe it could be included in the documentation?

[antrik]

@carllerche since almost all users need to handle it, and not doing so is a common source of subtle errors, I certainly wouldn't consider having it in the examples as noise. Examples should show good usage -- as a template for actual programs -- not something overly simplified that nobody should actually use as is.

(For the same reason, the examples probably shouldn't use a ridiculously large event buffer, which caused the performance problems in servo/ipc-channel#94 ...)

[carllerche]

I would be open to having two fns. Poll::poll and maybe Poll::interruptible_poll that doesn't handle it.

Thoughts @alexcrichton

[alexcrichton]

I'm not currently aware of any concrete use case to actually handle EINTR, so I'd be fine changing the behavior to handle EINTR and just leave the door open to adding a second fn in the future which doesn't handle it.