Allow certain tests to run on the Uno #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ d150fdf
Click for full report table
Click for full report CSV |
|
Memory usage change @ 09702de
Click for full report table
Click for full report CSV |
Owner
|
Looks good, thanks! I just corrected a few typos. Will merge soon. As this is not functionality critical, I propose not to throw a release just for this one. |
|
Memory usage change @ 7369158
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as it turns out the thing that does work on the Uno is shifting negative values by 0 bits (-1 << 0). Adjusted the guard to address Uno more selectively, and limit it to cases, where this applies.