Test the PS backend in the regression test framework.

Also fixes a bug in the ps backend found by doing so.

Author: mdboom

lib/matplotlib/testing/compare.py

@@ -132,7 +132,11 @@ def convert(filename):
    newname = base + '_' + extension + '.png'
    if not os.path.exists(filename):
       raise IOError, "'%s' does not exist" % filename
-   converter[extension](filename, newname)
+   # Only convert the file if the destination doesn't already exist or
+   # is out of date.
+   if (not os.path.exists(newname) or
+       os.stat(newname).st_mtime < os.stat(filename).st_mtime):
+      converter[extension](filename, newname)
    return newname
 
 verifiers = { }
@@ -163,6 +167,15 @@ def verify(filename):
    verifiers['svg'] = lambda filename: [
       'xmllint', '--valid', '--nowarning', '--noout', filename]
 
+def crop_to_same(actual_path, actual_image, expected_path, expected_image):
+   # clip the images to the same size -- this is useful only when
+   # comparing eps to pdf
+   if actual_path[-7:-4] == 'eps' and expected_path[-7:-4] == 'pdf':
+      aw, ah = actual_image.size
+      ew, eh = expected_image.size
+      actual_image = actual_image.crop((aw/2-ew/2, ah/2-eh/2, aw/2+ew/2, ah/2+eh/2))
+   return actual_image, expected_image
+
 def compare_images( expected, actual, tol, in_decorator=False ):
    '''Compare two image files - not the greatest, but fast and good enough.
 
@@ -199,12 +212,15 @@ def compare_images( expected, actual, tol, in_decorator=False ):
    # Convert the image to png
    extension = expected.split('.')[-1]
    if extension != 'png':
-      actual, expected = convert(actual), convert(expected)
+      actual = convert(actual)
+      expected = convert(expected)
 
    # open the image files and remove the alpha channel (if it exists)
    expectedImage = Image.open( expected ).convert("RGB")
    actualImage = Image.open( actual ).convert("RGB")
 
+   actualImage, expectedImage = crop_to_same(actual, actualImage, expected, expectedImage)
+
    # normalize the images
    expectedImage = ImageOps.autocontrast( expectedImage, 2 )
    actualImage = ImageOps.autocontrast( actualImage, 2 )
@@ -251,10 +267,13 @@ def compare_images( expected, actual, tol, in_decorator=False ):
 
 def save_diff_image( expected, actual, output ):
    from PIL import Image
-   expectedImage = np.array(Image.open( expected ).convert("RGB")).astype(np.float)
-   actualImage = np.array(Image.open( actual ).convert("RGB")).astype(np.float)
-   assert expectedImage.ndim==expectedImage.ndim
-   assert expectedImage.shape==expectedImage.shape
+   expectedImage = Image.open( expected ).convert("RGB")
+   actualImage = Image.open( actual ).convert("RGB")
+   actualImage, expectedImage = crop_to_same(actual, actualImage, expected, expectedImage)
+   expectedImage = np.array(expectedImage).astype(np.float)
+   actualImage = np.array(actualImage).astype(np.float)
+   assert expectedImage.ndim==actualImage.ndim
+   assert expectedImage.shape==actualImage.shape
    absDiffImage = abs(expectedImage-actualImage)
    # expand differences in luminance domain
    absDiffImage *= 10

lib/matplotlib/testing/decorators.py

@@ -96,7 +96,9 @@ def test(self):
                     fail_msg = 'No failure expected'
 
                 orig_expected_fname = os.path.join(baseline_dir, baseline) + '.' + extension
-                expected_fname = os.path.join(result_dir, 'expected-' + baseline) + '.' + extension
+                if extension == 'eps' and not os.path.exists(orig_expected_fname):
+                    orig_expected_fname = os.path.join(baseline_dir, baseline) + '.pdf'
+                expected_fname = os.path.join(result_dir, 'expected-' + os.path.basename(orig_expected_fname))
                 actual_fname = os.path.join(result_dir, baseline) + '.' + extension
                 if os.path.exists(orig_expected_fname):
                     shutil.copyfile(orig_expected_fname, expected_fname)
@@ -110,11 +112,12 @@ def test(self):
                 def do_test():
                     figure.savefig(actual_fname)
 
+                    err = compare_images(expected_fname, actual_fname, self._tol, in_decorator=True)
+
                     if not os.path.exists(expected_fname):
                         raise ImageComparisonFailure(
                             'image does not exist: %s' % expected_fname)
 
-                    err = compare_images(expected_fname, actual_fname, self._tol, in_decorator=True)
                     if err:
                         raise ImageComparisonFailure(
                             'images not close: %(actual)s vs. %(expected)s '
@@ -150,7 +153,7 @@ def image_comparison(baseline_images=None, extensions=None, tol=1e-3):
 
     if extensions is None:
         # default extensions to test
-        extensions = ['png', 'pdf', 'svg']
+        extensions = ['png', 'pdf', 'svg', 'eps']
 
     def compare_images_decorator(func):
         # We want to run the setup function (the actual test function

lib/matplotlib/tests/test_image.py

@@ -104,7 +104,7 @@ def test_image_clip():
 
     im = ax.imshow(d, extent=(-pi,pi,-pi/2,pi/2))
 
-@image_comparison(baseline_images=['imshow'])
+@image_comparison(baseline_images=['imshow'], tol=1.5e-3)
 def test_imshow():
     import numpy as np
     import matplotlib.pyplot as plt

lib/matplotlib/tests/test_legend.py

@@ -5,7 +5,7 @@
 from nose.tools import assert_raises
 from numpy.testing import assert_array_equal
 
-@image_comparison(baseline_images=['legend_auto1'])
+@image_comparison(baseline_images=['legend_auto1'], tol=1.5e-3)
 def test_legend_auto1():
     'Test automatic legend placement'
     fig = plt.figure()

lib/matplotlib/tests/test_png.py

@@ -4,7 +4,7 @@
 import glob
 import os
 
-@image_comparison(baseline_images=['pngsuite'])
+@image_comparison(baseline_images=['pngsuite'], extensions=['png'])
 def test_pngsuite():
     dirname = os.path.join(
         os.path.dirname(__file__),

ttconv/pprdrv_tt.cpp

@@ -437,7 +437,7 @@ void ttfont_header(TTStreamWriter& stream, struct TTFONT *font)
         stream.putline("/FontMatrix[.001 0 0 .001 0 0]def");
     }
 
-    stream.printf("/FontBBox[%d %d %d %d]def\n",font->llx,font->lly,font->urx,font->ury);
+    stream.printf("/FontBBox[%d %d %d %d]def\n",font->llx-1,font->lly-1,font->urx,font->ury);
     if (font->target_type == PS_TYPE_42 || font->target_type == PS_TYPE_42_3_HYBRID)
     {
         stream.printf("/FontType 42 def\n", font->target_type );