Skip to content

Conversation

@yungwine
Copy link
Collaborator

No description provided.

@yungwine yungwine requested a review from Copilot April 28, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@yungwine yungwine requested a review from Copilot April 28, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents the node upgrade from proceeding if the installed clang version is lower than 16. Key changes include:

  • Adding a clang version check in the Upgrade function.
  • Introducing a helper function (get_clang_major_version) to extract the clang major version.
Comments suppressed due to low confidence (1)

mytonctrl/mytonctrl.py:373

  • [nitpick] For improved readability of the error output, consider appending an explicit newline character after the instructions URL so that the message isn't concatenated onto the end of the URL.
			text += "Could not check clang version.\n If you are sure that clang version is 16 or higher, use --force option.\n"

@yungwine yungwine merged commit d0353a8 into ton-blockchain:dev Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant